[zanata/zanata-server] 890bae: refactor(editor): use jsf page for editor index fi...

GitHub noreply at github.com
Thu Oct 20 06:17:36 UTC 2016


  Branch: refs/heads/damason/change-some-paths/ZNTA-1279
  Home:   https://github.com/zanata/zanata-server
  Commit: 890bae45a46e3dd2d0c77eb9cabd8f22a757becc
      https://github.com/zanata/zanata-server/commit/890bae45a46e3dd2d0c77eb9cabd8f22a757becc
  Author: David Mason <drdmason at gmail.com>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M zanata-frontend/pom.xml
    M zanata-frontend/src/editor/app/index.html
    R zanata-frontend/src/editor/gulpfile.js
    R zanata-frontend/src/editor/gulpfile.paths.js
    M zanata-frontend/src/editor/makefile
    M zanata-frontend/src/editor/npm-shrinkwrap.json
    M zanata-frontend/src/editor/package.json
    M zanata-war/src/main/java/org/zanata/servlet/UrlRewriteConfig.java
    A zanata-war/src/main/webapp/editor/index.xhtml

  Log Message:
  -----------
  refactor(editor): use jsf page for editor index file

This is needed because the script paths have to be accurate.
The editor has been using local script paths but they will be
disrupted when the editor is behind a redirect. It would be
bad to redirect the script requests as well since we want browsers
to cache them.
Also removes gulp since no gulp tasks are being used.


  Commit: 2d2eec47d008d2c9c03bba0b81c433213b2af78f
      https://github.com/zanata/zanata-server/commit/2d2eec47d008d2c9c03bba0b81c433213b2af78f
  Author: David Mason <drdmason at gmail.com>
  Date:   2016-09-22 (Thu, 22 Sep 2016)

  Changed paths:
    M zanata-frontend/pom.xml
    M zanata-frontend/src/editor/app/api/index.js
    M zanata-war/src/main/webapp/editor/index.xhtml

  Log Message:
  -----------
  refactor: change editor files location from 'app' to 'editor'

This is the path the files will be served from, before it is modified by any
URL rewrite rules.


  Commit: ead594af429cce359ed7e138314eb4c9ef73d3d7
      https://github.com/zanata/zanata-server/commit/ead594af429cce359ed7e138314eb4c9ef73d3d7
  Author: David Mason <drdmason at gmail.com>
  Date:   2016-09-22 (Thu, 22 Sep 2016)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/servlet/UrlRewriteConfig.java

  Log Message:
  -----------
  docs: add comment about different possuble URLs for editor.


  Commit: 78f472f9fa26684431d46c526183a79f3e8a0470
      https://github.com/zanata/zanata-server/commit/78f472f9fa26684431d46c526183a79f3e8a0470
  Author: David Mason <drdmason at gmail.com>
  Date:   2016-09-22 (Thu, 22 Sep 2016)

  Changed paths:
    A zanata-frontend/src/editor/app/config/dev.js
    A zanata-frontend/src/editor/app/config/prod.js

  Log Message:
  -----------
  add separate dev and prod config modules for editor

This is to easily switch on the few differences between the development
build and the production build of the editor. Webpack is responsible for
providing the correct config module to the import call.
All configuration differences in the editor application code must be
included here. It is an error to switch on a production/development flag
anywhere else in the code.
Reasoning: differences between dev and prod builds introduce potential
for production bugs that are not noticed during development. We should
make it easy to see all the differences so that we can accurately assess
this risk. The differences should never be nested in application code,
and it should be easy to tell when there may be differences - by recognizing
that config is being imported.


  Commit: 8e65e4a33fa2c7692043dda0e72914fbe2733063
      https://github.com/zanata/zanata-server/commit/8e65e4a33fa2c7692043dda0e72914fbe2733063
  Author: David Mason <drdmason at gmail.com>
  Date:   2016-09-22 (Thu, 22 Sep 2016)

  Changed paths:
    M etc/scripts/quickbuild.sh
    M zanata-frontend/src/editor/app/api/index.js
    M zanata-frontend/src/editor/package.json

  Log Message:
  -----------
  WIP: FASTER DEV BUILDS *DO NOT CHECK IN*


Compare: https://github.com/zanata/zanata-server/compare/890bae45a46e^...8e65e4a33fa2


More information about the zanata-commits mailing list