[zanata/zanata-platform] 010dcc: refactor(TransUnitFilter): linting fixes

GitHub noreply at github.com
Fri Jul 7 08:29:05 UTC 2017


  Branch: refs/heads/damason/advanced-search/ZNTA-975
  Home:   https://github.com/zanata/zanata-platform
  Commit: 010dcc923dc2b5d0371f1a0ffdc4ca313f168e3f
      https://github.com/zanata/zanata-platform/commit/010dcc923dc2b5d0371f1a0ffdc4ca313f168e3f
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-07 (Fri, 07 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/TransUnitFilter.test.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/ui-reducer.test.js

  Log Message:
  -----------
  refactor(TransUnitFilter): linting fixes


  Commit: c47a7335dfb576e2d43802d8f4d57b21ae90f50a
      https://github.com/zanata/zanata-platform/commit/c47a7335dfb576e2d43802d8f4d57b21ae90f50a
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-07 (Fri, 07 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/TransUnitFilter.test.js
    M server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js
    R server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer.test.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.test.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/index.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-filter-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/ui-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/ui-reducer.test.js
    M server/zanata-frontend/src/frontend/app/editor/utils/filter-paging-util.js
    M server/zanata-frontend/src/frontend/package.json
    M server/zanata-frontend/src/frontend/yarn.lock

  Log Message:
  -----------
  refactor(editor filter): move status filter data to state.phrases.filter

The status filtering is all about filtering the list of phrases, so
it belongs in the phrase section with advanced search filter data which
will soon be added.
This change will help reduce the amount of distant data that reducers need
to access.


  Commit: 610ecd49cdf00bb90a4af7afbb71b1e4ad18bdcd
      https://github.com/zanata/zanata-platform/commit/610ecd49cdf00bb90a4af7afbb71b1e4ad18bdcd
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-07 (Fri, 07 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/controls-header-actions.js
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-action-types.js
    A server/zanata-frontend/src/frontend/app/editor/actions/phrases-filter-actions.js
    M server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.test.js

  Log Message:
  -----------
  refactor(editor filter): move phrase status filter actions to phrases-filter-actions

This includes making the TransUnitFilter component a completely connected
component deriving all its props from mapStateToProps and mapDispatchToProps.
All the components in the headers should move in this direction, so that
the header components can stick to the single responsibility of defining
the layout of the other components.


  Commit: b325a458900728125eab466b0b35cf2716291417
      https://github.com/zanata/zanata-platform/commit/b325a458900728125eab466b0b35cf2716291417
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-07 (Fri, 07 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-filter-actions.js
    M server/zanata-frontend/src/frontend/app/editor/index.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.js

  Log Message:
  -----------
  refactor(phrase filter): use flux standard actions for status filter

All the actions will be updated to be flux standard actions (FSAs), and
I have edited these actions, so this is an appropriate time to update
them.
This also removes the warning for using a non-symbol as an action type,
since all action types will be changed to strings so that they are
serializable (required for advanced development tools such as time-travel
debugging).


  Commit: cba03f9a76c577fd689ff3e125c50ce28060ffe8
      https://github.com/zanata/zanata-platform/commit/cba03f9a76c577fd689ff3e125c50ce28060ffe8
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-07 (Fri, 07 Jul 2017)

  Changed paths:
    A server/zanata-frontend/src/frontend/app/editor/components/PhraseStatusFilter/PhraseStatusFilter.test.js
    A server/zanata-frontend/src/frontend/app/editor/components/PhraseStatusFilter/index.js
    R server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/TransUnitFilter.test.js
    R server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js

  Log Message:
  -----------
  refactor: rename TransUnitFilter to PhraseStatusFilter


  Commit: f116077fa9b027b8a2ffd2357e53e4dcfdfd4e42
      https://github.com/zanata/zanata-platform/commit/f116077fa9b027b8a2ffd2357e53e4dcfdfd4e42
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-07 (Fri, 07 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/frontend/app/editor/components/PhraseStatusFilter/PhraseStatusFilter.test.js
    R server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer.test.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.test.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-filter-reducer.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-filter-reducer.test.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-reducer.test.js

  Log Message:
  -----------
  feat(ZNTA-975): add advanced search state, actions and reducer


  Commit: 809360c082479aff707457b902e5557f409c3d53
      https://github.com/zanata/zanata-platform/commit/809360c082479aff707457b902e5557f409c3d53
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-07 (Fri, 07 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/EditorSearchInput.test.js

  Log Message:
  -----------
  test: fix linting warnings in EditorSearchInput.test.js


  Commit: f7d8da934575825e1a1d035e3fe8f307b1ad70a7
      https://github.com/zanata/zanata-platform/commit/f7d8da934575825e1a1d035e3fe8f307b1ad70a7
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-07 (Fri, 07 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-filter-actions.js
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/EditorSearchInput.story.js
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/EditorSearchInput.test.js
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js

  Log Message:
  -----------
  feat(ZNTA-975): connect EditorSearchInput to app and state


Compare: https://github.com/zanata/zanata-platform/compare/010dcc923dc2^...f7d8da934575


More information about the zanata-commits mailing list