[zanata/zanata-platform] 1eaada: Fix static analysis warnings

[GitHub]

  Branch: refs/heads/server-split
  Home:   https://github.com/zanata/zanata-platform
  Commit: 1eaadab99bfe221bb4981e77ad982a3c9a428914
      https://github.com/zanata/zanata-platform/commit/1eaadab99bfe221bb4981e77ad982a3c9a428914
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2017-07-19 (Wed, 19 Jul 2017)

  Changed paths:
    M server/gwt-editor/src/test/java/org/zanata/webtrans/client/presenter/DocumentListPresenterTest.java
    M server/gwt-editor/src/test/java/org/zanata/webtrans/client/presenter/EditorKeyShortcutsTest.java
    M server/gwt-editor/src/test/java/org/zanata/webtrans/client/presenter/EditorTranslatorsTest.java
    M server/gwt-editor/src/test/java/org/zanata/webtrans/client/presenter/TargetContentsPresenterTest.java
    M server/gwt-shared/pom.xml
    M server/gwt-test/pom.xml
    M server/services/pom.xml
    M server/zanata-model-test/src/main/resources/org/zanata/test/model/TMXTestData.dbunit.xml
    M server/zanata-model-test/src/main/resources/org/zanata/test/model/TextFlowTestData.dbunit.xml

  Log Message:
  -----------
  Fix static analysis warnings


  Commit: ebf5ef626f3c6521e77c20e91ccd1743ba8f4834
      https://github.com/zanata/zanata-platform/commit/ebf5ef626f3c6521e77c20e91ccd1743ba8f4834
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2017-07-19 (Wed, 19 Jul 2017)

  Changed paths:
    M server/pom.xml
    M server/services/pom.xml
    M server/services/src/test/java/org/zanata/action/AccountMergeActionTest.java
    M server/services/src/test/java/org/zanata/action/LanguageActionTest.java
    R server/services/src/test/java/org/zanata/model/TestFixture.java
    M server/services/src/test/java/org/zanata/rest/editor/service/StatisticsServiceTest.java
    M server/services/src/test/java/org/zanata/rest/editor/service/TransMemoryMergeManagerTest.java
    M server/services/src/test/java/org/zanata/rest/editor/service/UserServiceTest.java
    M server/services/src/test/java/org/zanata/service/impl/CopyTransServiceUnitTest.java
    M server/services/src/test/java/org/zanata/service/impl/GlossarySearchServiceImplTest.java
    M server/services/src/test/java/org/zanata/service/impl/TextFlowSearchServiceImplTest.java
    M server/services/src/test/java/org/zanata/ui/ActivityEntryTest.java
    M server/services/src/test/java/org/zanata/util/TranslationUtilTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/TranslationWorkspaceImplTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/TranslationWorkspaceManagerImplTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/ActivateWorkspaceHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/EventServiceConnectedHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/ExitWorkspaceHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetDocumentListHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetGlossaryDetailsHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetLocaleListHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetProjectTransUnitListsHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetTargetForLocaleHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetTransMemoryDetailsHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetTransUnitListHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetTranslationHistoryHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetTranslatorListHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/PreviewReplaceTextHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/PublishWorkspaceChatHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/RevertTransUnitUpdatesHandlerTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/TransUnitEditHandlerTest.java
    M server/zanata-model-test/src/main/java/org/zanata/test/EntityTestData.java
    M server/zanata-model/src/main/java/org/zanata/model/ModelEntityBase.java
    M server/zanata-model/src/main/java/org/zanata/model/po/HPoTargetHeader.java
    M server/zanata-model/src/test/java/org/zanata/model/po/HPoTargetHeaderTest.java

  Log Message:
  -----------
  Reduce setId visibility; replace TestFixture


Compare: https://github.com/zanata/zanata-platform/compare/2948c7d8151e...ebf5ef626f3c