[zanata/zanata-platform] 974bd7: refactor(TransUnitFilter): linting fixes

Mon Jul 24 04:06:18 UTC 2017

  Branch: refs/heads/damason/advanced-search/ZNTA-975
  Home:   https://github.com/zanata/zanata-platform
  Commit: 974bd7b11e10d9c2dac09347bc2f2479cbbeee90
      https://github.com/zanata/zanata-platform/commit/974bd7b11e10d9c2dac09347bc2f2479cbbeee90
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/TransUnitFilter.test.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/ui-reducer.test.js

  Log Message:
  -----------
  refactor(TransUnitFilter): linting fixes

  Commit: 215e8c518f08d500436ce6946224f9c5d893de4c
      https://github.com/zanata/zanata-platform/commit/215e8c518f08d500436ce6946224f9c5d893de4c
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/TransUnitFilter.test.js
    M server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js
    R server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer.test.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.test.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/index.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-filter-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/ui-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/ui-reducer.test.js
    M server/zanata-frontend/src/frontend/app/editor/utils/filter-paging-util.js
    M server/zanata-frontend/src/frontend/package.json
    M server/zanata-frontend/src/frontend/yarn.lock

  Log Message:
  -----------
  refactor(editor filter): move status filter data to state.phrases.filter

The status filtering is all about filtering the list of phrases, so
it belongs in the phrase section with advanced search filter data which
will soon be added.
This change will help reduce the amount of distant data that reducers need
to access.

  Commit: d05b66af63966afdbd8978ef2a616249f5cd6cf9
      https://github.com/zanata/zanata-platform/commit/d05b66af63966afdbd8978ef2a616249f5cd6cf9
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/controls-header-actions.js
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-action-types.js
    A server/zanata-frontend/src/frontend/app/editor/actions/phrases-filter-actions.js
    M server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.test.js

  Log Message:
  -----------
  refactor(editor filter): move phrase status filter actions to phrases-filter-actions

This includes making the TransUnitFilter component a completely connected
component deriving all its props from mapStateToProps and mapDispatchToProps.
All the components in the headers should move in this direction, so that
the header components can stick to the single responsibility of defining
the layout of the other components.

  Commit: fee736847dc59d8095dff9cf6a3dc0d00f409d08
      https://github.com/zanata/zanata-platform/commit/fee736847dc59d8095dff9cf6a3dc0d00f409d08
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-filter-actions.js
    M server/zanata-frontend/src/frontend/app/editor/index.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.js

  Log Message:
  -----------
  refactor(phrase filter): use flux standard actions for status filter

All the actions will be updated to be flux standard actions (FSAs), and
I have edited these actions, so this is an appropriate time to update
them.
This also removes the warning for using a non-symbol as an action type,
since all action types will be changed to strings so that they are
serializable (required for advanced development tools such as time-travel
debugging).

  Commit: 77297b7a74d80d90df146963e3a533ffed0168ad
      https://github.com/zanata/zanata-platform/commit/77297b7a74d80d90df146963e3a533ffed0168ad
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    A server/zanata-frontend/src/frontend/app/editor/components/PhraseStatusFilter/PhraseStatusFilter.test.js
    A server/zanata-frontend/src/frontend/app/editor/components/PhraseStatusFilter/index.js
    R server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/TransUnitFilter.test.js
    R server/zanata-frontend/src/frontend/app/editor/components/TransUnitFilter/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js

  Log Message:
  -----------
  refactor: rename TransUnitFilter to PhraseStatusFilter

  Commit: f80fb09728450776f6f6fa0f724a2c7d6f5b8219
      https://github.com/zanata/zanata-platform/commit/f80fb09728450776f6f6fa0f724a2c7d6f5b8219
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/frontend/app/editor/components/PhraseStatusFilter/PhraseStatusFilter.test.js
    R server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer.test.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.test.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-filter-reducer.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-filter-reducer.test.js
    A server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-reducer.test.js

  Log Message:
  -----------
  feat(ZNTA-975): add advanced search state, actions and reducer

  Commit: d6290aa65816099fdc53c5ab2e1f6614bf08ebab
      https://github.com/zanata/zanata-platform/commit/d6290aa65816099fdc53c5ab2e1f6614bf08ebab
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/EditorSearchInput.test.js

  Log Message:
  -----------
  test: fix linting warnings in EditorSearchInput.test.js

  Commit: 9f7455ae1d690a9cd1112644ea44da34aa98fd9c
      https://github.com/zanata/zanata-platform/commit/9f7455ae1d690a9cd1112644ea44da34aa98fd9c
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-filter-actions.js
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/EditorSearchInput.story.js
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/EditorSearchInput.test.js
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js

  Log Message:
  -----------
  feat(ZNTA-975): connect EditorSearchInput to app and state

  Commit: abcd8875d94adfd176297853fd00f3959920cd89
      https://github.com/zanata/zanata-platform/commit/abcd8875d94adfd176297853fd00f3959920cd89
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M api/zanata-common-api/src/main/java/org/zanata/rest/service/ProjectVersionResource.java
    M server/zanata-war/src/main/java/org/zanata/rest/service/ProjectVersionService.java
    M server/zanata-war/src/main/java/org/zanata/util/DateUtil.java
    M server/zanata-war/src/main/java/org/zanata/webtrans/server/rpc/GetTransUnitListHandler.java
    M server/zanata-war/src/test/java/org/zanata/rest/service/ProjectVersionServiceUnitTest.java

  Log Message:
  -----------
  feat(ZNTA-975): add filter fields to status list endpoint

  Commit: 9b8573965c6327e7cc2a47f7cdec998e22fa5596
      https://github.com/zanata/zanata-platform/commit/9b8573965c6327e7cc2a47f7cdec998e22fa5596
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js

  Log Message:
  -----------
  feat(ZNTA-975): apply style class to input component

Includes a FIXME comment because the css classes need to be moved for
maintainability.

  Commit: b207644e4cd814dcd677f936fc490e5201d23f29
      https://github.com/zanata/zanata-platform/commit/b207644e4cd814dcd677f936fc490e5201d23f29
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/index.js
    A server/zanata-frontend/src/frontend/app/editor/setup-middlewares.js

  Log Message:
  -----------
  refactor(editor): move middleware config to separate module

  Commit: e38572616a8ecea77080f3a46572bff63e5bd4b5
      https://github.com/zanata/zanata-platform/commit/e38572616a8ecea77080f3a46572bff63e5bd4b5
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    A server/zanata-frontend/src/frontend/app/editor/selectors/index.js
    M server/zanata-frontend/src/frontend/package.json
    M server/zanata-frontend/src/frontend/yarn.lock

  Log Message:
  -----------
  feat(ZNTA-975): add selectors for current page of phrases

These are not used yet, but selectors should replace most places that we
are manually pulling out or calculating pieces of state from the store.
They will allow changing in one place if we move some state, and will
be more efficient for calculated state since they memoize the input selectors.

  Commit: 4d6da9174667c570abb4129c85d366efb3ddc32f
      https://github.com/zanata/zanata-platform/commit/4d6da9174667c570abb4129c85d366efb3ddc32f
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/api/index.js

  Log Message:
  -----------
  feat(ZNTA-975): allow filter parameters in phrase fetch request

  Commit: 07e8855fe6a96d569dcc7a6f5b6605992160c9d5
      https://github.com/zanata/zanata-platform/commit/07e8855fe6a96d569dcc7a6f5b6605992160c9d5
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/frontend/app/editor/api/index.js
    M server/zanata-frontend/src/frontend/app/editor/index.js
    M server/zanata-frontend/src/frontend/app/editor/selectors/index.js
    A server/zanata-frontend/src/frontend/app/editor/watchers/filtered-phrases.js
    A server/zanata-frontend/src/frontend/app/editor/watchers/index.js
    A server/zanata-frontend/src/frontend/app/editor/watchers/visible-phrases.js

  Log Message:
  -----------
  WIP: fetch filter phrases from server (NOT USED YET)

  Commit: 6fddc8f38b9d392d56f48d1f84bd44499cd7277d
      https://github.com/zanata/zanata-platform/commit/6fddc8f38b9d392d56f48d1f84bd44499cd7277d
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/frontend/app/editor/watchers/filtered-phrases.js
    A server/zanata-frontend/src/frontend/app/editor/watchers/watch.js

  Log Message:
  -----------
  WIP: add logging wrapper around redux-watch

  Commit: 872e4b9a34f7e7c2500d4d08553c8d5ef2a34f99
      https://github.com/zanata/zanata-platform/commit/872e4b9a34f7e7c2500d4d08553c8d5ef2a34f99
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/frontend/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/frontend/app/editor/middlewares/new-context-fetch.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-reducer.test.js
    M server/zanata-frontend/src/frontend/app/editor/selectors/index.js
    A server/zanata-frontend/src/frontend/app/editor/utils/log-todo.js
    M server/zanata-frontend/src/frontend/app/editor/utils/status-util.js
    R server/zanata-frontend/src/frontend/app/editor/watchers/filtered-phrases.js
    M server/zanata-frontend/src/frontend/app/editor/watchers/index.js
    A server/zanata-frontend/src/frontend/app/editor/watchers/page-number.js
    A server/zanata-frontend/src/frontend/app/editor/watchers/phrase-detail.js
    A server/zanata-frontend/src/frontend/app/editor/watchers/phrase-list.js
    R server/zanata-frontend/src/frontend/app/editor/watchers/visible-phrases.js

  Log Message:
  -----------
  feat(ZNTA-975): fetch and store server-filtered phrase list

Does not yet display the fetched list.

  Commit: 4aec24e29cf588c646b882adae7739fa895a6e72
      https://github.com/zanata/zanata-platform/commit/4aec24e29cf588c646b882adae7739fa895a6e72
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/selectors/index.js

  Log Message:
  -----------
  feat(ZNTA-975): add selector for hasAdvancedFilter

  Commit: 4ce8880aec5cd131c86a215e33cbfc9d9b448dfb
      https://github.com/zanata/zanata-platform/commit/4ce8880aec5cd131c86a215e33cbfc9d9b448dfb
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/containers/MainContent.js
    M server/zanata-frontend/src/frontend/app/editor/selectors/index.js
    M server/zanata-frontend/src/frontend/app/editor/utils/filter-paging-util.js

  Log Message:
  -----------
  feat(ZNTA-975): display filtered phrases when filter is present

  Commit: f57e8d9b2a787d72074cc959742e76becd204b0b
      https://github.com/zanata/zanata-platform/commit/f57e8d9b2a787d72074cc959742e76becd204b0b
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/actions/controls-header-actions.js
    M server/zanata-frontend/src/frontend/app/editor/containers/ControlsHeader.js
    M server/zanata-frontend/src/frontend/app/editor/containers/Root/index.js
    M server/zanata-frontend/src/frontend/app/editor/middlewares/new-context-fetch.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/frontend/app/editor/selectors/index.js
    R server/zanata-frontend/src/frontend/app/editor/utils/filter-paging-util.js

  Log Message:
  -----------
  feat(ZNTA-975): WIP fixing all phrase list refs for filter, fixed paging

Paging was using old location, changed to use selectors to it will adapt
when selectors change next time.

  Commit: 3ad2ad72bbea9361bd06d8bf2864fb6ddb5e4b36
      https://github.com/zanata/zanata-platform/commit/3ad2ad72bbea9361bd06d8bf2864fb6ddb5e4b36
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/index.js
    A server/zanata-frontend/src/frontend/app/editor/middlewares/index.js
    R server/zanata-frontend/src/frontend/app/editor/middlewares/selected-phrase-searches.js
    M server/zanata-frontend/src/frontend/app/editor/selectors/index.js
    R server/zanata-frontend/src/frontend/app/editor/setup-middlewares.js
    M server/zanata-frontend/src/frontend/app/editor/watchers/index.js
    A server/zanata-frontend/src/frontend/app/editor/watchers/selected-phrase-searches.js

  Log Message:
  -----------
  feat(ZNTA-975): use watcher for glossary and suggestion searches

Includes moving middleware setup to middlewares/index.js since that
makes more sense and keeps the top level cleaner.

  Commit: 3bc5b3430c83db0d9336ea04fd4b370ee334aab7
      https://github.com/zanata/zanata-platform/commit/3bc5b3430c83db0d9336ea04fd4b370ee334aab7
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/EditorSearchInput.story.js

  Log Message:
  -----------
  fix(setState): use callback form of setState for search input

The other form has a theoretical state-clobbering bug.

  Commit: 154d540ae044a30f0d245ed750529500ff83899c
      https://github.com/zanata/zanata-platform/commit/154d540ae044a30f0d245ed750529500ff83899c
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/frontend/app/editor/selectors/index.js

  Log Message:
  -----------
  feat(ZNTA-975): only select first row when unfiltered list is loaded

  Commit: 6d1455a6b463be4641af54e00abd8615a6c3dcab
      https://github.com/zanata/zanata-platform/commit/6d1455a6b463be4641af54e00abd8615a6c3dcab
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-07-24 (Mon, 24 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/EditorSearchInput.test.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-filter-reducer.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-filter-reducer.test.js
    M server/zanata-frontend/src/frontend/app/editor/reducers/phrase-reducer/phrase-reducer.test.js

  Log Message:
  -----------
  test(ZNTA-975): update tests to work with plain/filtered status lists

Compare: https://github.com/zanata/zanata-platform/compare/5b6aba6374af...6d1455a6b463