[zanata/zanata-platform] 40bdfa: fix(ZNTA-2133): Close modal on ESC keydown or on c...

GitHub noreply at github.com
Sun Jul 30 23:29:26 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/zanata/zanata-platform
  Commit: 40bdfa8bfcc988972d0488a9ca73e0aa785b1c87
      https://github.com/zanata/zanata-platform/commit/40bdfa8bfcc988972d0488a9ca73e0aa785b1c87
  Author: Earl Floden <efloden at redhat.com>
  Date:   2017-07-25 (Tue, 25 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/containers/ProjectVersion/TMMergeModal.js

  Log Message:
  -----------
  fix(ZNTA-2133): Close modal on ESC keydown or on click outside


  Commit: 77a82a612e338ed549f5859b20d9d524e6151656
      https://github.com/zanata/zanata-platform/commit/77a82a612e338ed549f5859b20d9d524e6151656
  Author: Earl Floden <efloden at redhat.com>
  Date:   2017-07-26 (Wed, 26 Jul 2017)

  Changed paths:
    M server/zanata-war/src/main/java/org/zanata/action/VersionGroupHome.java
    M server/zanata-war/src/main/java/org/zanata/security/SecurityFunctions.java
    M server/zanata-war/src/main/java/org/zanata/util/UrlUtil.java
    M server/zanata-war/src/main/webapp/WEB-INF/layout/version-group/settings-tab.xhtml
    M server/zanata-war/src/main/webapp/resources/assets/css/style.css
    M server/zanata-war/src/main/webapp/resources/assets/fonts/zanata-v6/selection.json

  Log Message:
  -----------
  Merge branch 'master' of github.com:zanata/zanata-platform into ZNTA-2133-esc-modal


  Commit: aa086141ea7a21d3cdba0f1aa4c33645af3dd0ce
      https://github.com/zanata/zanata-platform/commit/aa086141ea7a21d3cdba0f1aa4c33645af3dd0ce
  Author: efloden <earl.mark.27 at gmail.com>
  Date:   2017-07-28 (Fri, 28 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/containers/ProjectVersion/TMMergeModal.js
    M server/zanata-frontend/src/frontend/app/containers/ProjectVersion/index.js
    M server/zanata-frontend/src/frontend/app/jsf/index.js
    M server/zanata-war/src/main/webapp/iteration/view.xhtml

  Log Message:
  -----------
  refactor(ZNTA-2133): function/prop rename and library use

Renaming the openTMMergeModal function/prop to toggleTMMergeModal
Using specialkeys library to determine 'esc' keypress in modal


  Commit: bdf527d9f0f76fcd7dfd6f0e2195122cbf8212e6
      https://github.com/zanata/zanata-platform/commit/bdf527d9f0f76fcd7dfd6f0e2195122cbf8212e6
  Author: efloden <earl.mark.27 at gmail.com>
  Date:   2017-07-28 (Fri, 28 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/components/Modal/index.jsx
    M server/zanata-frontend/src/frontend/app/containers/ProjectVersion/TMMergeModal.js

  Log Message:
  -----------
  feat(ZNTA-2133): Move esc and click close functionaly to Modal component

Implmented the 'esc' key closing and clicking outside the modal closing in the Modal component with keydown and backdrop props, default to false to maintain current functionality of the Modal component in other places


  Commit: c1235557d64e7bb4fd620f1fba80ee64aebec09a
      https://github.com/zanata/zanata-platform/commit/c1235557d64e7bb4fd620f1fba80ee64aebec09a
  Author: Earl Floden <efloden at redhat.com>
  Date:   2017-07-31 (Mon, 31 Jul 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/components/Modal/index.jsx
    M server/zanata-frontend/src/frontend/app/containers/ProjectVersion/TMMergeModal.js
    M server/zanata-frontend/src/frontend/app/containers/ProjectVersion/index.js
    M server/zanata-frontend/src/frontend/app/jsf/index.js
    M server/zanata-war/src/main/webapp/iteration/view.xhtml

  Log Message:
  -----------
  Merge pull request #448 from zanata/ZNTA-2133-esc-modal

fix(ZNTA-2133): Close TM merge modal on ESC keydown or on click outside


Compare: https://github.com/zanata/zanata-platform/compare/429236958b8e...c1235557d64e


More information about the zanata-commits mailing list