[zanata/zanata-platform] 6f0cee: Switch to JDT compiler; other static analysis chan...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/zanata/zanata-platform
  Commit: 6f0ceeea2cf3d727f7e125bb582147ead4b1543e
      https://github.com/zanata/zanata-platform/commit/6f0ceeea2cf3d727f7e125bb582147ead4b1543e
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M Jenkinsfile
    M api/zanata-common-api/src/main/java/org/zanata/common/DocumentType.java
    M build-tools/pom.xml
    M build-tools/src/main/resources/zanata-build-tools/detekt.yml
    M client/zanata-client-commands/src/main/java/org/zanata/client/commands/push/RawPushCommand.java
    M client/zanata-client-commands/src/test/java/org/zanata/client/commands/UpdateCheckerTest.java
    M client/zanata-maven-plugin/pom.xml
    M client/zanata-maven-plugin/src/main/java/org/zanata/maven/AbstractPushPullMojo.java
    M parent/pom.xml
    M server/functional-test/pom.xml
    M server/functional-test/src/test/java/org/zanata/util/HasEmailRule.java
    M server/gwt-editor/src/main/java/org/zanata/webtrans/client/view/TransMemoryView.java
    M server/pom.xml
    M server/security-common/pom.xml
    M server/zanata-model/pom.xml
    M server/zanata-model/src/main/java/org/zanata/model/HDocument.java
    M server/zanata-model/src/main/java/org/zanata/model/HLocale.kt
    M server/zanata-model/src/main/java/org/zanata/tmx/TMXUtil.java
    M server/zanata-test-war/pom.xml
    M server/zanata-test-war/src/main/java/org/zanata/rest/SampleDataResourceImpl.java
    M server/zanata-war/pom.xml
    M server/zanata-war/src/main/java/org/zanata/dao/LocaleDAO.kt
    M server/zanata-war/src/main/java/org/zanata/rest/JaxRSApplication.java
    M server/zanata-war/src/main/java/org/zanata/service/impl/UserAccountServiceImpl.java

  Log Message:
  -----------
  Switch to JDT compiler; other static analysis changes (#395)

- Eliminate double compilation in server (maven-compiler plus takari-lifecycle)
- Switch to Eclipse JDT compiler to restore lots of missing warnings
 - Avoids unhelpful annotation warnings (JDK-6999068)
 - Also warns about a lot of new things (eg imports)
- Increase javac warnings threshold to match JDT warnings
- Fix some compiler warnings
- Fix new FindBugs warnings triggered by JDT's bytecode
- Change ArgumentCaptor to handle varargs in test
- Lower FindBugs warnings thresholds to 0
- Use warnings parser for Kotlin (custom)
- Update detekt, assertj
 - Add workaround for arturbosch/detekt#89
 - Simplify Kotlin functions with detekt
- Remove gitdescribe duplicate logging
- Improve activation of staticAnalysis Maven profile