[zanata/zanata-platform] 5e5d78: refactor(warnings): Use final on potentially mutab...

[GitHub]

  Branch: refs/heads/qe-fix-warnings-2
  Home:   https://github.com/zanata/zanata-platform
  Commit: 5e5d786ad730b47dd5a8978f79d24e8ec9210ab2
      https://github.com/zanata/zanata-platform/commit/5e5d786ad730b47dd5a8978f79d24e8ec9210ab2
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-08 (Wed, 08 Mar 2017)

  Changed paths:
    M server/zanata-war/src/main/java/org/zanata/rest/editor/service/TransUnitUtils.java
    A server/zanata-war/src/test/java/org/zanata/rest/editor/service/TransUnitUtilsTest.java

  Log Message:
  -----------
  refactor(warnings): Use final on potentially mutable fields


  Commit: 5a324894e680c2a89427546b64995444b3e0ad32
      https://github.com/zanata/zanata-platform/commit/5a324894e680c2a89427546b64995444b3e0ad32
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-08 (Wed, 08 Mar 2017)

  Changed paths:
    M server/functional-test/src/main/java/org/zanata/workflow/ClientWorkFlow.java

  Log Message:
  -----------
  refactor(warnings): Move warning suppression to correct place


  Commit: 2a05a2136d96b3f38a4f2527bae31a330c25e071
      https://github.com/zanata/zanata-platform/commit/2a05a2136d96b3f38a4f2527bae31a330c25e071
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-08 (Wed, 08 Mar 2017)

  Changed paths:
    M server/functional-test/src/main/java/org/zanata/page/WebDriverFactory.java

  Log Message:
  -----------
  refactor(warnings): Check for null DswidIDChecker before accessing


  Commit: 2909d022b985397cd8f3dbad48619e4e06c65e26
      https://github.com/zanata/zanata-platform/commit/2909d022b985397cd8f3dbad48619e4e06c65e26
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-09 (Thu, 09 Mar 2017)

  Changed paths:
    M server/zanata-model/src/main/java/org/zanata/model/Activity.java
    M server/zanata-model/src/main/java/org/zanata/model/AllowedApp.java
    M server/zanata-model/src/main/java/org/zanata/model/HApplicationConfiguration.java

  Log Message:
  -----------
  refactor(warnings): Override equals and hashcode


  Commit: 3b5aa51f4bbec7c045c46202298914d3c108bc7d
      https://github.com/zanata/zanata-platform/commit/3b5aa51f4bbec7c045c46202298914d3c108bc7d
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-09 (Thu, 09 Mar 2017)

  Changed paths:
    M server/functional-test/src/main/java/org/zanata/page/WebDriverFactory.java
    M server/zanata-model/src/main/java/org/zanata/model/HAccountActivationKey.java
    M server/zanata-model/src/main/java/org/zanata/model/HApplicationConfiguration.java
    M server/zanata-model/src/main/java/org/zanata/model/HDocumentHistory.java
    M server/zanata-model/src/main/java/org/zanata/model/HPersonEmailValidationKey.java
    M server/zanata-model/src/main/java/org/zanata/model/HSimpleComment.java
    M server/zanata-model/src/main/java/org/zanata/model/HTextFlowTarget.java
    M server/zanata-war/src/main/java/org/zanata/action/CacheAction.java
    M server/zanata-war/src/main/java/org/zanata/action/LanguageAction.java
    M server/zanata-war/src/main/java/org/zanata/action/ProjectHome.java
    M server/zanata-war/src/main/java/org/zanata/action/ProjectHomeAction.java
    M server/zanata-war/src/main/java/org/zanata/action/RoleAssignmentRuleAction.java
    M server/zanata-war/src/main/java/org/zanata/action/VersionGroupHome.java
    M server/zanata-war/src/main/java/org/zanata/action/validator/DomainListValidator.java
    M server/zanata-war/src/main/java/org/zanata/adapter/HTMLAdapter.java
    M server/zanata-war/src/main/java/org/zanata/adapter/SubtitleAdapter.java
    M server/zanata-war/src/main/java/org/zanata/dao/DocumentDAO.java
    M server/zanata-war/src/main/java/org/zanata/service/impl/EmailServiceImpl.java
    M server/zanata-war/src/main/java/org/zanata/ui/ajax/commandbutton/CommandButtonRenderer.java
    M server/zanata-war/src/main/java/org/zanata/util/PasswordUtil.java
    M server/zanata-war/src/main/resources/messages.properties
    M server/zanata-war/src/test/java/org/zanata/rest/editor/service/TransUnitUtilsTest.java
    A server/zanata-war/src/test/java/org/zanata/service/impl/EmailServiceImplTest.java

  Log Message:
  -----------
  refactor(warnings): Various findbugs fixes


Compare: https://github.com/zanata/zanata-platform/compare/5e5d786ad730^...3b5aa51f4bbe