[zanata/zanata-platform] 7d00a8: refactor(warnings): Use final on potentially mutab...

[GitHub]

  Branch: refs/heads/qe-fix-warnings-2
  Home:   https://github.com/zanata/zanata-platform
  Commit: 7d00a8964affd5ece7de4e306299aa26fe5f9202
      https://github.com/zanata/zanata-platform/commit/7d00a8964affd5ece7de4e306299aa26fe5f9202
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-09 (Thu, 09 Mar 2017)

  Changed paths:
    M server/zanata-war/src/main/java/org/zanata/rest/editor/service/TransUnitUtils.java
    A server/zanata-war/src/test/java/org/zanata/rest/editor/service/TransUnitUtilsTest.java

  Log Message:
  -----------
  refactor(warnings): Use final on potentially mutable fields


  Commit: 531fd1cdbfe718bb354e231b31dcc63f1e06db7c
      https://github.com/zanata/zanata-platform/commit/531fd1cdbfe718bb354e231b31dcc63f1e06db7c
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-09 (Thu, 09 Mar 2017)

  Changed paths:
    M server/functional-test/src/main/java/org/zanata/workflow/ClientWorkFlow.java

  Log Message:
  -----------
  refactor(warnings): Move warning suppression to correct place


  Commit: db2eed02411caf404c48120eaf177d8eb8bc43e8
      https://github.com/zanata/zanata-platform/commit/db2eed02411caf404c48120eaf177d8eb8bc43e8
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-09 (Thu, 09 Mar 2017)

  Changed paths:
    M server/functional-test/src/main/java/org/zanata/page/WebDriverFactory.java

  Log Message:
  -----------
  refactor(warnings): Check for null DswidIDChecker before accessing


  Commit: 3a6d7126dd23e8fb32cc55e042ae0deb1738ec12
      https://github.com/zanata/zanata-platform/commit/3a6d7126dd23e8fb32cc55e042ae0deb1738ec12
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-09 (Thu, 09 Mar 2017)

  Changed paths:
    M server/zanata-model/src/main/java/org/zanata/model/Activity.java
    M server/zanata-model/src/main/java/org/zanata/model/AllowedApp.java
    M server/zanata-model/src/main/java/org/zanata/model/HApplicationConfiguration.java

  Log Message:
  -----------
  refactor(warnings): Override equals and hashcode


  Commit: 8efdb9c4c7c6926e74184d69178e4e55c5a4a67e
      https://github.com/zanata/zanata-platform/commit/8efdb9c4c7c6926e74184d69178e4e55c5a4a67e
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-03-09 (Thu, 09 Mar 2017)

  Changed paths:
    M server/functional-test/src/main/java/org/zanata/page/WebDriverFactory.java
    M server/zanata-model/src/main/java/org/zanata/model/HAccountActivationKey.java
    M server/zanata-model/src/main/java/org/zanata/model/HApplicationConfiguration.java
    M server/zanata-model/src/main/java/org/zanata/model/HDocumentHistory.java
    M server/zanata-model/src/main/java/org/zanata/model/HPersonEmailValidationKey.java
    M server/zanata-model/src/main/java/org/zanata/model/HSimpleComment.java
    M server/zanata-model/src/main/java/org/zanata/model/HTextFlowTarget.java
    M server/zanata-war/src/main/java/org/zanata/action/CacheAction.java
    M server/zanata-war/src/main/java/org/zanata/action/LanguageAction.java
    M server/zanata-war/src/main/java/org/zanata/action/ProjectHome.java
    M server/zanata-war/src/main/java/org/zanata/action/ProjectHomeAction.java
    M server/zanata-war/src/main/java/org/zanata/action/RoleAssignmentRuleAction.java
    M server/zanata-war/src/main/java/org/zanata/action/VersionGroupHome.java
    M server/zanata-war/src/main/java/org/zanata/action/validator/DomainListValidator.java
    M server/zanata-war/src/main/java/org/zanata/adapter/HTMLAdapter.java
    M server/zanata-war/src/main/java/org/zanata/adapter/SubtitleAdapter.java
    M server/zanata-war/src/main/java/org/zanata/dao/DocumentDAO.java
    M server/zanata-war/src/main/java/org/zanata/service/impl/EmailServiceImpl.java
    M server/zanata-war/src/main/java/org/zanata/ui/ajax/commandbutton/CommandButtonRenderer.java
    M server/zanata-war/src/main/java/org/zanata/util/PasswordUtil.java
    M server/zanata-war/src/main/resources/messages.properties
    M server/zanata-war/src/test/java/org/zanata/action/NewProfileActionTest.java
    A server/zanata-war/src/test/java/org/zanata/model/HAccountActivationKeyTest.java
    M server/zanata-war/src/test/java/org/zanata/rest/editor/service/TransUnitUtilsTest.java
    A server/zanata-war/src/test/java/org/zanata/service/impl/EmailServiceImplTest.java

  Log Message:
  -----------
  refactor(warnings): Various findbugs fixes


Compare: https://github.com/zanata/zanata-platform/compare/3b5aa51f4bbe...8efdb9c4c7c6