[zanata/zanata-platform] 64ffb1: feat(ZNTA-1735): show icons in storybook without d...

GitHub noreply at github.com
Thu Mar 30 04:55:19 UTC 2017


  Branch: refs/heads/ZNTA-1735-editorglossary
  Home:   https://github.com/zanata/zanata-platform
  Commit: 64ffb14c80613118f40f7a9ae4c029a9d366d0c8
      https://github.com/zanata/zanata-platform/commit/64ffb14c80613118f40f7a9ae4c029a9d366d0c8
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-03-30 (Thu, 30 Mar 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/GlossarySearchInput/index.js
    M server/zanata-frontend/src/frontend/app/editor/components/GlossarySearchInput/story.js
    M server/zanata-frontend/src/frontend/app/editor/components/GlossaryTerm/index.js
    M server/zanata-frontend/src/frontend/app/editor/components/GlossaryTerm/story.js
    M server/zanata-frontend/src/frontend/app/editor/components/GlossaryTermModal/story.js

  Log Message:
  -----------
  feat(ZNTA-1735): show icons in storybook without duplicating icon svg

Including an <Icons /> component more than once in the component tree
will insert multiple copies of the icon svg onto the page. This will
bloat the memory use of the page, and could impact performance in
other ways.
The correct approach at the moment is to use .addDecorator in each
story.js file (for components that use any icons).




More information about the zanata-commits mailing list