[zanata/zanata-platform] 4acc92: refactor(frontend): stop using manual binding on R...

GitHub noreply at github.com
Mon May 22 01:28:01 UTC 2017


  Branch: refs/heads/damason/react-upgrade-prep/ZNTA-1953
  Home:   https://github.com/zanata/zanata-platform
  Commit: 4acc9239ab4b7770c822a4ae0f01178dc184e27c
      https://github.com/zanata/zanata-platform/commit/4acc9239ab4b7770c822a4ae0f01178dc184e27c
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-05-17 (Wed, 17 May 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/editor/components/EditorSearchInput/EditorSearchInput.story.js
    M server/zanata-frontend/src/frontend/app/editor/containers/Root/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/Sidebar/index.js

  Log Message:
  -----------
  refactor(frontend): stop using manual binding on React component methods

Using arrow functions when defining a custom method on a component
allows the method to be passed as a callback without the need to
manually bind it. Custom methods are any that are not React lifecycle
methods.


  Commit: 287fa15b7b88aeab0ad5d22d92fac57f107863c6
      https://github.com/zanata/zanata-platform/commit/287fa15b7b88aeab0ad5d22d92fac57f107863c6
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-05-22 (Mon, 22 May 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/components/EditableText/index.js
    M server/zanata-frontend/src/frontend/app/components/Notification/component.js
    M server/zanata-frontend/src/frontend/app/components/TextInput/index.js
    M server/zanata-frontend/src/frontend/app/containers/App.js
    M server/zanata-frontend/src/frontend/app/containers/Explore/index.js
    M server/zanata-frontend/src/frontend/app/containers/Glossary/DeleteAllEntriesModal.jsx
    M server/zanata-frontend/src/frontend/app/containers/Glossary/DeleteEntryModal.jsx
    M server/zanata-frontend/src/frontend/app/containers/Glossary/Entry.js
    M server/zanata-frontend/src/frontend/app/containers/Glossary/EntryModal.js
    M server/zanata-frontend/src/frontend/app/containers/Glossary/ExportModal.js
    M server/zanata-frontend/src/frontend/app/containers/Glossary/ImportModal.js
    M server/zanata-frontend/src/frontend/app/containers/Glossary/NewEntryModal.js
    M server/zanata-frontend/src/frontend/app/containers/Glossary/ViewHeader.js
    M server/zanata-frontend/src/frontend/app/containers/Glossary/index.js
    M server/zanata-frontend/src/frontend/app/containers/Languages/DeleteEntry.js
    M server/zanata-frontend/src/frontend/app/containers/Languages/Entry.js
    M server/zanata-frontend/src/frontend/app/containers/Languages/NewLanguageModal.js
    M server/zanata-frontend/src/frontend/app/containers/Languages/index.js
    M server/zanata-frontend/src/frontend/app/containers/Root.js
    M server/zanata-frontend/src/frontend/app/containers/UserProfile/index.jsx
    M server/zanata-frontend/src/frontend/app/editor/containers/ParamPropDispatcher.js
    M server/zanata-frontend/src/frontend/app/editor/containers/Sidebar/index.js
    M server/zanata-frontend/src/frontend/app/editor/containers/SuggestionDetailsModal/PlainSuggestionContents.js
    M server/zanata-frontend/src/frontend/app/editor/containers/SuggestionDetailsModal/index.js

  Log Message:
  -----------
  refactor(ZNTA-1953): use static field for component propTypes and arrow functions for custom methods

This is to make all class-based components consistent in how they
specify propTypes and non-lifecycle methods.


Compare: https://github.com/zanata/zanata-platform/compare/fd1f7b1e478e...287fa15b7b88


More information about the zanata-commits mailing list