[zanata/zanata-platform] addbab: fix(glossary): defactor glossary to use binding in...

GitHub noreply at github.com
Mon May 22 08:10:20 UTC 2017


  Branch: refs/heads/damason/react-upgrade-prep/ZNTA-1953
  Home:   https://github.com/zanata/zanata-platform
  Commit: addbab3204e52d0fe3f9acb99addddd9ccc7ef37
      https://github.com/zanata/zanata-platform/commit/addbab3204e52d0fe3f9acb99addddd9ccc7ef37
  Author: David Mason <drdmason at gmail.com>
  Date:   2017-05-22 (Mon, 22 May 2017)

  Changed paths:
    M server/zanata-frontend/src/frontend/app/containers/Glossary/index.js

  Log Message:
  -----------
  fix(glossary): defactor glossary to use binding inline in JSX to satisfy react-list

The old version of react-list we are using seems to break unless we bind the
update function inline - worst-practice but it just does not work when binding
in the constructor or let React bind it by using an arrow function.

The render function does not appear to be part of the newer API for react-list,
it takes a child component as a template instead. Updating to the new version
may help bring us in line with good practice.




More information about the zanata-commits mailing list