[zanata/zanata-platform] 3de645: fix(ZNTA-2247): Remove magic numbers for glossary ...

[GitHub]

  Branch: refs/heads/znta-2247-find-glossary-columns
  Home:   https://github.com/zanata/zanata-platform
  Commit: 3de64571e3f570d7c61677ffdf68268e2d774051
      https://github.com/zanata/zanata-platform/commit/3de64571e3f570d7c61677ffdf68268e2d774051
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-11-02 (Thu, 02 Nov 2017)

  Changed paths:
    M common/zanata-adapter-glossary/src/main/java/org/zanata/adapter/glossary/GlossaryCSVReader.java

  Log Message:
  -----------
  fix(ZNTA-2247): Remove magic numbers for glossary csv columns

Still expects column 0 to be the source locale, but checks that the
PoS and Description columns are named. This prevents garbage in
said fields.
This change also prevents repeatedly setting these fields, only
doing so once per row.


  Commit: a32fd95515bb456ae3c3933f772874fbe778eb02
      https://github.com/zanata/zanata-platform/commit/a32fd95515bb456ae3c3933f772874fbe778eb02
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-11-02 (Thu, 02 Nov 2017)

  Changed paths:
    M common/zanata-adapter-glossary/src/main/java/org/zanata/adapter/glossary/GlossaryCSVReader.java
    M common/zanata-adapter-glossary/src/test/java/org/zanata/adapter/glossary/GlossaryCSVReaderTest.java
    M common/zanata-adapter-glossary/src/test/resources/glossary/translate1.csv
    M common/zanata-adapter-glossary/src/test/resources/glossary/translate2.csv

  Log Message:
  -----------
  fix(ZNTA-2247): Allow several synonyms for data fields

Fix invalid test, contradicting the specified behaviour.


  Commit: 9195d2e6cce864929c45bc92d384e55c9b1d8d05
      https://github.com/zanata/zanata-platform/commit/9195d2e6cce864929c45bc92d384e55c9b1d8d05
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-11-02 (Thu, 02 Nov 2017)

  Changed paths:
    M common/zanata-adapter-glossary/src/main/java/org/zanata/adapter/glossary/GlossaryCSVReader.java
    M common/zanata-adapter-glossary/src/test/java/org/zanata/adapter/glossary/GlossaryCSVReaderTest.java

  Log Message:
  -----------
  fix(ZNTA-2247): remove duplication of srclang terms


Compare: https://github.com/zanata/zanata-platform/compare/49922a60400d...9195d2e6cce8