[zanata/zanata-platform] 332a30: fix(ZNTA-2247): Remove magic numbers for glossary ...

[GitHub]

  Branch: refs/heads/znta-2247-find-glossary-columns
  Home:   https://github.com/zanata/zanata-platform
  Commit: 332a30c2bd7cd9d2e17f25ff662e25b5ad2affe3
      https://github.com/zanata/zanata-platform/commit/332a30c2bd7cd9d2e17f25ff662e25b5ad2affe3
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-11-13 (Mon, 13 Nov 2017)

  Changed paths:
    M common/zanata-adapter-glossary/src/main/java/org/zanata/adapter/glossary/GlossaryCSVReader.java

  Log Message:
  -----------
  fix(ZNTA-2247): Remove magic numbers for glossary csv columns

Still expects column 0 to be the source locale, but checks that the
PoS and Description columns are named. This prevents garbage in
said fields.
This change also prevents repeatedly setting these fields, only
doing so once per row.


  Commit: 6e8b72aebfa4eec77ce8962a3d929f5ff6c00c74
      https://github.com/zanata/zanata-platform/commit/6e8b72aebfa4eec77ce8962a3d929f5ff6c00c74
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-11-13 (Mon, 13 Nov 2017)

  Changed paths:
    M common/zanata-adapter-glossary/src/main/java/org/zanata/adapter/glossary/GlossaryCSVReader.java
    M common/zanata-adapter-glossary/src/test/java/org/zanata/adapter/glossary/GlossaryCSVReaderTest.java
    M common/zanata-adapter-glossary/src/test/resources/glossary/translate1.csv
    M common/zanata-adapter-glossary/src/test/resources/glossary/translate2.csv

  Log Message:
  -----------
  fix(ZNTA-2247): Allow several synonyms for data fields

Fix invalid test, contradicting the specified behaviour.


  Commit: 6bdb5e990d48512d07c3e9792d36fee82e066329
      https://github.com/zanata/zanata-platform/commit/6bdb5e990d48512d07c3e9792d36fee82e066329
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2017-11-13 (Mon, 13 Nov 2017)

  Changed paths:
    M common/zanata-adapter-glossary/src/main/java/org/zanata/adapter/glossary/GlossaryCSVReader.java
    M common/zanata-adapter-glossary/src/test/java/org/zanata/adapter/glossary/GlossaryCSVReaderTest.java

  Log Message:
  -----------
  fix(ZNTA-2247): remove duplication of srclang terms


Compare: https://github.com/zanata/zanata-platform/compare/9195d2e6cce8...6bdb5e990d48