[zanata/zanata-platform] 89a952: fix(ZNTA-2247): Remove magic numbers for glossary ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/zanata/zanata-platform
  Commit: 89a95219b404085a857304862366983c0d841c7d
      https://github.com/zanata/zanata-platform/commit/89a95219b404085a857304862366983c0d841c7d
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-01-11 (Thu, 11 Jan 2018)

  Changed paths:
    M common/zanata-adapter-glossary/src/main/java/org/zanata/adapter/glossary/GlossaryCSVReader.java
    M common/zanata-adapter-glossary/src/test/java/org/zanata/adapter/glossary/GlossaryCSVReaderTest.java
    M common/zanata-adapter-glossary/src/test/resources/glossary/translate1.csv
    M common/zanata-adapter-glossary/src/test/resources/glossary/translate2.csv
    M docs/user-guide/glossary/upload-glossaries.md

  Log Message:
  -----------
  fix(ZNTA-2247): Remove magic numbers for glossary csv columns (#592)

* fix(ZNTA-2247): Remove magic numbers for glossary csv columns
Still expects column 0 to be the source locale, but checks that the
PoS and Description columns are named. This prevents garbage in
said fields.
This change also prevents repeatedly setting these fields, only
doing so once per row.
* fix(ZNTA-2247): Allow several synonyms for data fields
Fix invalid test, contradicting the specified behaviour.
* fix(ZNTA-2247): Add docs and improve code as per review