[zanata/zanata-platform] 608f90: feat(ZNTA-2635): editor validators error behavior ...

[GitHub]

  Branch: refs/heads/ZNTA-2529
  Home:   https://github.com/zanata/zanata-platform
  Commit: 608f90779dccaf75eeb7d7ae2423105a3eba9de2
      https://github.com/zanata/zanata-platform/commit/608f90779dccaf75eeb7d7ae2423105a3eba9de2
  Author: Earl Floden <efloden at redhat.com>
  Date:   2018-07-06 (Fri, 06 Jul 2018)

  Changed paths:
    M server/zanata-frontend/src/.storybook-editor/__snapshots__/storyshots-editor.test.js.snap
    M server/zanata-frontend/src/app/editor/actions/key-shortcuts-actions.js
    M server/zanata-frontend/src/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationFooter.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationHeader.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/Validation.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/index.tsx
    A server/zanata-frontend/src/app/editor/components/ValidationErrorsModal/index.tsx
    M server/zanata-frontend/src/app/editor/containers/TranslationInfoPanel/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/app/editor/utils/phrase-util.ts
    M server/zanata-frontend/src/app/editor/utils/phrase.ts
    M server/zanata-frontend/src/app/editor/utils/status-util.ts
    M server/zanata-frontend/src/app/editor/watchers/phrase-detail.js
    M server/zanata-frontend/src/app/validators/AbstractValidationAction.ts
    M server/zanata-frontend/src/app/validators/ValidationMessages.ts
    M server/zanata-frontend/src/app/validators/impl/JavaVariablesValidation.ts
    M server/zanata-frontend/src/app/validators/impl/PrintfVariablesValidation.ts
    M server/zanata-frontend/src/app/validators/impl/PrintfXSIExtensionValidation.test.js
    M server/zanata-frontend/src/app/validators/impl/XmlEntityValidation.test.js

  Log Message:
  -----------
  feat(ZNTA-2635): editor validators error behavior (#924)

* feat: editor behavior on validation errors detected

* feat: track validation error detections for transunits,
display error notification icon in status area, hide validation messages panel when not selected

* refactor: retrieve phrases errors status from redux store

* test: update jest tests, snapshots

* fix: unstage vscode settings

* refactor: remove unneeded let

* fix: typescript errors

* chore: fix typescript strict warnings

* feat: use modal to confirm saving with validation errors

* fix: typescript strict checks, tests

* refactor: save with validation errors modal to SFC component

* refactor: remove Errors detected message

* fix: typo, clarify move to next row logic


  Commit: 591b7444fc697460c509387ba7345bb3bc1a417c
      https://github.com/zanata/zanata-platform/commit/591b7444fc697460c509387ba7345bb3bc1a417c
  Author: Kathryn Gough <kgough at redhat.com>
  Date:   2018-07-06 (Fri, 06 Jul 2018)

  Changed paths:
    M server/zanata-frontend/src/.storybook-editor/__snapshots__/storyshots-editor.test.js.snap
    M server/zanata-frontend/src/app/editor/actions/key-shortcuts-actions.js
    M server/zanata-frontend/src/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationFooter.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/Validation.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/index.tsx
    A server/zanata-frontend/src/app/editor/components/ValidationErrorsModal/index.tsx
    M server/zanata-frontend/src/app/editor/containers/TranslationInfoPanel/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/app/editor/utils/phrase-util.ts
    M server/zanata-frontend/src/app/editor/utils/phrase.ts
    M server/zanata-frontend/src/app/editor/utils/status-util.ts
    M server/zanata-frontend/src/app/editor/watchers/phrase-detail.js
    M server/zanata-frontend/src/app/validators/AbstractValidationAction.ts
    M server/zanata-frontend/src/app/validators/ValidationMessages.ts
    M server/zanata-frontend/src/app/validators/impl/JavaVariablesValidation.ts
    M server/zanata-frontend/src/app/validators/impl/PrintfVariablesValidation.ts
    M server/zanata-frontend/src/app/validators/impl/PrintfXSIExtensionValidation.test.js
    M server/zanata-frontend/src/app/validators/impl/XmlEntityValidation.test.js

  Log Message:
  -----------
  Merge branch 'master' into ZNTA-2529


Compare: https://github.com/zanata/zanata-platform/compare/01043dc3f6fa...591b7444fc69
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.