[zanata/zanata-platform] 608f90: feat(ZNTA-2635): editor validators error behavior ...

GitHub noreply at github.com
Wed Jul 11 23:27:18 UTC 2018


  Branch: refs/heads/webpack-upgrade/ZNTA-2652
  Home:   https://github.com/zanata/zanata-platform
  Commit: 608f90779dccaf75eeb7d7ae2423105a3eba9de2
      https://github.com/zanata/zanata-platform/commit/608f90779dccaf75eeb7d7ae2423105a3eba9de2
  Author: Earl Floden <efloden at redhat.com>
  Date:   2018-07-06 (Fri, 06 Jul 2018)

  Changed paths:
    M server/zanata-frontend/src/.storybook-editor/__snapshots__/storyshots-editor.test.js.snap
    M server/zanata-frontend/src/app/editor/actions/key-shortcuts-actions.js
    M server/zanata-frontend/src/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationFooter.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationHeader.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/Validation.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/index.tsx
    A server/zanata-frontend/src/app/editor/components/ValidationErrorsModal/index.tsx
    M server/zanata-frontend/src/app/editor/containers/TranslationInfoPanel/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/app/editor/utils/phrase-util.ts
    M server/zanata-frontend/src/app/editor/utils/phrase.ts
    M server/zanata-frontend/src/app/editor/utils/status-util.ts
    M server/zanata-frontend/src/app/editor/watchers/phrase-detail.js
    M server/zanata-frontend/src/app/validators/AbstractValidationAction.ts
    M server/zanata-frontend/src/app/validators/ValidationMessages.ts
    M server/zanata-frontend/src/app/validators/impl/JavaVariablesValidation.ts
    M server/zanata-frontend/src/app/validators/impl/PrintfVariablesValidation.ts
    M server/zanata-frontend/src/app/validators/impl/PrintfXSIExtensionValidation.test.js
    M server/zanata-frontend/src/app/validators/impl/XmlEntityValidation.test.js

  Log Message:
  -----------
  feat(ZNTA-2635): editor validators error behavior (#924)

* feat: editor behavior on validation errors detected

* feat: track validation error detections for transunits,
display error notification icon in status area, hide validation messages panel when not selected

* refactor: retrieve phrases errors status from redux store

* test: update jest tests, snapshots

* fix: unstage vscode settings

* refactor: remove unneeded let

* fix: typescript errors

* chore: fix typescript strict warnings

* feat: use modal to confirm saving with validation errors

* fix: typescript strict checks, tests

* refactor: save with validation errors modal to SFC component

* refactor: remove Errors detected message

* fix: typo, clarify move to next row logic


  Commit: 90307bdada96bdd2fa56ecc994c5a38a34e594b5
      https://github.com/zanata/zanata-platform/commit/90307bdada96bdd2fa56ecc994c5a38a34e594b5
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2018-07-10 (Tue, 10 Jul 2018)

  Changed paths:
    M server/zanata-frontend/src/.eslintrc
    M server/zanata-frontend/src/app/actions/common-actions.ts
    M server/zanata-frontend/src/app/actions/glossary-actions.js
    M server/zanata-frontend/src/app/actions/tmx-actions.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.js
    M server/zanata-frontend/src/app/reducers/common-reducer.js
    M server/zanata-frontend/src/app/reducers/explore-reducer.js
    M server/zanata-frontend/src/app/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/reducers/languages-reducer.js
    M server/zanata-frontend/src/app/reducers/profile-reducer.js
    A server/zanata-frontend/src/app/reducers/state.ts
    M server/zanata-frontend/src/app/reducers/tmx-reducer.js
    M server/zanata-frontend/src/app/utils/DateHelper.ts
    A server/zanata-frontend/src/app/utils/DeepReadonly.d.ts
    M server/zanata-frontend/src/app/utils/prop-types-util.ts
    M server/zanata-frontend/src/tslint.json

  Log Message:
  -----------
  Add incomplete types for Redux state (#945)

* Add incomplete types for Redux state
* Update eslintrc
* Fix accidental state mutation of state.importFile


  Commit: 5910479655f7fac5aed454edffb28d0e002301e4
      https://github.com/zanata/zanata-platform/commit/5910479655f7fac5aed454edffb28d0e002301e4
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2018-07-10 (Tue, 10 Jul 2018)

  Changed paths:
    R server/zanata-frontend/src/app/editor/components/GlossaryTermModal/index.js
    A server/zanata-frontend/src/app/editor/components/GlossaryTermModal/index.ts
    M server/zanata-frontend/src/app/editor/reducers/activity-reducer.js
    R server/zanata-frontend/src/app/editor/reducers/context-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/context-reducer.test.js
    A server/zanata-frontend/src/app/editor/reducers/context-reducer.ts
    R server/zanata-frontend/src/app/editor/reducers/dropdown-reducer.js
    A server/zanata-frontend/src/app/editor/reducers/dropdown-reducer.ts
    M server/zanata-frontend/src/app/editor/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/header-data-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/phrase-filter-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/settings-reducer.js
    A server/zanata-frontend/src/app/editor/reducers/state.ts
    M server/zanata-frontend/src/app/editor/reducers/suggestions-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/ui-reducer.js

  Log Message:
  -----------
  Add some state types for editor


  Commit: 207096f54ecda8ab87247236fb8693bef7e2b339
      https://github.com/zanata/zanata-platform/commit/207096f54ecda8ab87247236fb8693bef7e2b339
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2018-07-10 (Tue, 10 Jul 2018)

  Changed paths:
    M server/zanata-frontend/src/app/components/Icon/index.tsx
    M server/zanata-frontend/src/app/utils/prop-types-util.ts
    M server/zanata-frontend/src/package.json
    M server/zanata-frontend/src/yarn.lock

  Log Message:
  -----------
  Add io-ts and prop-types-ts for Icon


  Commit: 981c061dee63c5c2137fd056606d75b98b049135
      https://github.com/zanata/zanata-platform/commit/981c061dee63c5c2137fd056606d75b98b049135
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2018-07-10 (Tue, 10 Jul 2018)

  Changed paths:
    M server/zanata-frontend/src/app/editor/components/ActivitySelectList/index.js
    M server/zanata-frontend/src/app/editor/containers/ActivityTab.tsx
    M server/zanata-frontend/src/app/editor/utils/activity-util.ts

  Log Message:
  -----------
  Use prop-types-ts for ActivityTab


  Commit: d4d04aff21e7231bed4f9eed1ae5c5435a2dce68
      https://github.com/zanata/zanata-platform/commit/d4d04aff21e7231bed4f9eed1ae5c5435a2dce68
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2018-07-11 (Wed, 11 Jul 2018)

  Changed paths:
    M server/zanata-frontend/src/app/components/Icon/index.tsx
    M server/zanata-frontend/src/app/editor/components/ActivitySelectList/index.js
    R server/zanata-frontend/src/app/editor/components/GlossaryTermModal/index.js
    A server/zanata-frontend/src/app/editor/components/GlossaryTermModal/index.ts
    M server/zanata-frontend/src/app/editor/containers/ActivityTab.tsx
    M server/zanata-frontend/src/app/editor/reducers/activity-reducer.js
    R server/zanata-frontend/src/app/editor/reducers/context-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/context-reducer.test.js
    A server/zanata-frontend/src/app/editor/reducers/context-reducer.ts
    R server/zanata-frontend/src/app/editor/reducers/dropdown-reducer.js
    A server/zanata-frontend/src/app/editor/reducers/dropdown-reducer.ts
    M server/zanata-frontend/src/app/editor/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/header-data-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/phrase-filter-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/settings-reducer.js
    A server/zanata-frontend/src/app/editor/reducers/state.ts
    M server/zanata-frontend/src/app/editor/reducers/suggestions-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/ui-reducer.js
    M server/zanata-frontend/src/app/editor/utils/activity-util.ts
    M server/zanata-frontend/src/app/utils/prop-types-util.ts
    M server/zanata-frontend/src/package.json
    M server/zanata-frontend/src/yarn.lock

  Log Message:
  -----------
  Merge pull request #947 from zanata/types-for-editor-state

Add types for editor state


  Commit: 836237239c72a23a9c979b7806d99931d93a5e4b
      https://github.com/zanata/zanata-platform/commit/836237239c72a23a9c979b7806d99931d93a5e4b
  Author: efloden <efloden at redhat.com>
  Date:   2018-07-12 (Thu, 12 Jul 2018)

  Changed paths:
    M server/zanata-frontend/src/.eslintrc
    M server/zanata-frontend/src/.storybook-editor/__snapshots__/storyshots-editor.test.js.snap
    M server/zanata-frontend/src/app/actions/common-actions.ts
    M server/zanata-frontend/src/app/actions/glossary-actions.js
    M server/zanata-frontend/src/app/actions/tmx-actions.js
    M server/zanata-frontend/src/app/components/Icon/index.tsx
    M server/zanata-frontend/src/app/editor/actions/key-shortcuts-actions.js
    M server/zanata-frontend/src/app/editor/actions/phrases-action-types.js
    M server/zanata-frontend/src/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/app/editor/components/ActivitySelectList/index.js
    R server/zanata-frontend/src/app/editor/components/GlossaryTermModal/index.js
    A server/zanata-frontend/src/app/editor/components/GlossaryTermModal/index.ts
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationFooter.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationHeader.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/Validation.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/index.tsx
    A server/zanata-frontend/src/app/editor/components/ValidationErrorsModal/index.tsx
    M server/zanata-frontend/src/app/editor/containers/ActivityTab.tsx
    M server/zanata-frontend/src/app/editor/containers/TranslationInfoPanel/index.js
    M server/zanata-frontend/src/app/editor/reducers/activity-reducer.js
    R server/zanata-frontend/src/app/editor/reducers/context-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/context-reducer.test.js
    A server/zanata-frontend/src/app/editor/reducers/context-reducer.ts
    R server/zanata-frontend/src/app/editor/reducers/dropdown-reducer.js
    A server/zanata-frontend/src/app/editor/reducers/dropdown-reducer.ts
    M server/zanata-frontend/src/app/editor/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/header-data-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/filter-status-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/index.js
    M server/zanata-frontend/src/app/editor/reducers/phrase-reducer/phrase-filter-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/review-trans-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/settings-reducer.js
    A server/zanata-frontend/src/app/editor/reducers/state.ts
    M server/zanata-frontend/src/app/editor/reducers/suggestions-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/ui-reducer.js
    M server/zanata-frontend/src/app/editor/utils/activity-util.ts
    M server/zanata-frontend/src/app/editor/utils/phrase-util.ts
    M server/zanata-frontend/src/app/editor/utils/phrase.ts
    M server/zanata-frontend/src/app/editor/utils/status-util.ts
    M server/zanata-frontend/src/app/editor/watchers/phrase-detail.js
    M server/zanata-frontend/src/app/reducers/admin-reducer.js
    M server/zanata-frontend/src/app/reducers/common-reducer.js
    M server/zanata-frontend/src/app/reducers/explore-reducer.js
    M server/zanata-frontend/src/app/reducers/glossary-reducer.js
    M server/zanata-frontend/src/app/reducers/languages-reducer.js
    M server/zanata-frontend/src/app/reducers/profile-reducer.js
    A server/zanata-frontend/src/app/reducers/state.ts
    M server/zanata-frontend/src/app/reducers/tmx-reducer.js
    M server/zanata-frontend/src/app/utils/DateHelper.ts
    A server/zanata-frontend/src/app/utils/DeepReadonly.d.ts
    M server/zanata-frontend/src/app/utils/prop-types-util.ts
    M server/zanata-frontend/src/app/validators/AbstractValidationAction.ts
    M server/zanata-frontend/src/app/validators/ValidationMessages.ts
    M server/zanata-frontend/src/app/validators/impl/JavaVariablesValidation.ts
    M server/zanata-frontend/src/app/validators/impl/PrintfVariablesValidation.ts
    M server/zanata-frontend/src/app/validators/impl/PrintfXSIExtensionValidation.test.js
    M server/zanata-frontend/src/app/validators/impl/XmlEntityValidation.test.js
    M server/zanata-frontend/src/package.json
    M server/zanata-frontend/src/tslint.json
    M server/zanata-frontend/src/yarn.lock

  Log Message:
  -----------
  Merge branch 'master' of github.com:zanata/zanata-platform into webpack-upgrade/ZNTA-2652


Compare: https://github.com/zanata/zanata-platform/compare/f31874408269...836237239c72
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the zanata-commits mailing list