[zanata/zanata-platform] 002d46: feat(ZNTA-75): Add live validations to React Edito...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/zanata/zanata-platform
  Commit: 002d46d70cea23facfe8f6e7d21ca2b1a9914a43
      https://github.com/zanata/zanata-platform/commit/002d46d70cea23facfe8f6e7d21ca2b1a9914a43
  Author: Earl Floden <efloden at redhat.com>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M server/functional-test/src/main/java/org/zanata/page/editor/ReactEditorPage.java
    M server/zanata-frontend/src/.storybook-editor/__snapshots__/storyshots-editor.test.js.snap
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.js
    M server/zanata-frontend/src/app/editor/components/TransUnitTranslationPanel.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/Validation.story.js
    A server/zanata-frontend/src/app/editor/components/Validation/Validation.test.js
    M server/zanata-frontend/src/app/editor/components/Validation/index.tsx
    M server/zanata-frontend/src/app/editor/containers/SettingsPanel.js
    M server/zanata-frontend/src/app/utils/FeatureToggles.ts
    A server/zanata-frontend/src/app/validators/AbstractValidationAction.ts
    A server/zanata-frontend/src/app/validators/ValidationAction.ts
    A server/zanata-frontend/src/app/validators/ValidationDisplayRules.ts
    A server/zanata-frontend/src/app/validators/ValidationMessages.ts
    A server/zanata-frontend/src/app/validators/impl/HtmlXmlTagValidation.test.js
    A server/zanata-frontend/src/app/validators/impl/HtmlXmlTagValidation.ts
    A server/zanata-frontend/src/app/validators/impl/JavaVariablesValidation.test.js
    A server/zanata-frontend/src/app/validators/impl/JavaVariablesValidation.ts
    A server/zanata-frontend/src/app/validators/impl/NewlineLeadTrailValidation.test.js
    A server/zanata-frontend/src/app/validators/impl/NewlineLeadTrailValidation.ts
    A server/zanata-frontend/src/app/validators/impl/PrintfVariablesValidation.test.js
    A server/zanata-frontend/src/app/validators/impl/PrintfVariablesValidation.ts
    A server/zanata-frontend/src/app/validators/impl/PrintfXSIExtensionValidation.test.js
    A server/zanata-frontend/src/app/validators/impl/PrintfXSIExtensionValidation.ts
    A server/zanata-frontend/src/app/validators/impl/TabValidation.test.js
    A server/zanata-frontend/src/app/validators/impl/TabValidation.ts
    A server/zanata-frontend/src/app/validators/impl/XmlEntityValidation.test.js
    A server/zanata-frontend/src/app/validators/impl/XmlEntityValidation.ts
    A server/zanata-frontend/src/app/validators/index.ts
    A server/zanata-frontend/src/app/validators/messages/en.json
    A server/zanata-frontend/src/app/validators/messages/fr.json
    A server/zanata-frontend/src/app/validators/messages/index.ts
    A server/zanata-frontend/src/app/validators/messages/ja.json
    M server/zanata-frontend/src/messages/ja.json
    M server/zanata-frontend/src/package.json
    M server/zanata-frontend/src/tsconfig.json
    M server/zanata-frontend/src/yarn.lock

  Log Message:
  -----------
  feat(ZNTA-75): Add live validations to React Editor (#809)

* feat: convert AbstractValidationAction class and interfaces to TS

* fix: AbstractValidationAction implementation

* refactor: ValidationMessages to use react-intl style messages

* feat: implement HtmlXmlTagValidation

* feat: create webpack config for Validators package, index.ts entrypoint

* feat: implement XmlEntityValidation, unit test

* feat: implement HtmlXmlTagValidation, partial unit tests

* feat: convert newlineleadtrailvalidation, tabvalidation validators

* feat: implement PrintfVariablesValidation

* test: TabValidation with jest

* test: HtmlXmlTagValidation, XmlEntityValidation, TabValidation jest tests

* test: PrintfVariablesValidation

* test: NewlineLeadTrailValidation

* feat: wip PrintVariablesValidation and jest test

* feat: implement JavaVariablesValidation and jest test

* feat: use intl-messageformat parser for validation i18n, test produced messages

* feat: wip integrate validators with frontend component (tabvalidator)

* feat: implement, test intl messages for PrintfVariablesValidation, XMLEntityValidation

* feat: use i18n messages for all validators, test results

* feat: use validation factory to generate validators, generate messages for all selected validation opts
Update Storybook to show each validator result

* feat: Integrate Validators with TransUnitTranslationPanel

* test: TransUnitTranslationPanel with Validator component, update storyshots

* feat: enable and integrate editor validation option settings

* fix: HtmlXmlValidation orderValidation method, test all message results

* fix: PrintfXSIExtensionValidation positional test

* test: update EditorAlphaTest to only check editor page, wait for page silence

* feat: Use JSON for intl message files

* feat: use translated intl messages based on selected locale for validators

* feat: localize Validation frontend UI

* chore: upgrade typescript at 2.9.1, utilize native JSON imports

* fix: don't validate empty translations

* fix: only display errors/warnings titles if warnings/errors exist

* test: Validation frontend component markup with jest

* refactor: move intl messages to validators module, remove feature switch

* test: update test class constructors

* refactor: remove ValidationID enum, move validationFactory to validators module,
shallow merge (extend) translated messages to default missing translations to english

* fix: unnecessary abstract class

* refactor: assert enDefault messages as ValidationMessages

* refactor: AbstractValidationAction, reduce Validators super arguments

* refactor: make messages protected, update HtmlXmlTagValidation

* Swap constructor param order



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.