[zanata/zanata-platform] c0e49d: feat(ZNTA-2297) Editor Activity Panel Backend (#72...

GitHub noreply at github.com
Thu Mar 22 23:22:13 UTC 2018 

  Branch: refs/heads/ZNTA-2407
  Home:   https://github.com/zanata/zanata-platform
  Commit: c0e49d76e2f2de080aac0625a193e2133a9f55a2
      https://github.com/zanata/zanata-platform/commit/c0e49d76e2f2de080aac0625a193e2133a9f55a2
  Author: Earl Floden <efloden at redhat.com>
  Date:   2018-03-20 (Tue, 20 Mar 2018)

  Changed paths:
    M server/gwt-editor/src/test/java/org/zanata/webtrans/client/presenter/TranslationHistoryPresenterTest.java
    M server/gwt-shared/src/main/java/org/zanata/webtrans/shared/model/ReviewComment.java
    M server/gwt-shared/src/main/java/org/zanata/webtrans/shared/model/TransHistoryItem.java
    M server/gwt-shared/src/main/java/org/zanata/webtrans/shared/model/TransUnitUpdateRequest.java
    M server/services/src/main/java/org/zanata/rest/editor/dto/TranslationData.java
    A server/services/src/main/java/org/zanata/rest/editor/service/TransUnitHistoryService.java
    M server/services/src/main/java/org/zanata/rest/editor/service/TranslationService.java
    A server/services/src/main/java/org/zanata/rest/editor/service/resource/TransUnitHistoryResource.java
    M server/services/src/main/java/org/zanata/rest/service/RestUtils.java
    M server/services/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java
    M server/services/src/main/java/org/zanata/webtrans/server/rpc/GetTranslationHistoryHandler.java
    M server/services/src/test/java/org/zanata/rest/editor/dto/TranslationDataTest.java
    A server/services/src/test/java/org/zanata/rest/editor/service/TransUnitHistoryServiceTest.java
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetTranslationHistoryHandlerTest.java
    M server/zanata-frontend/src/.storybook-editor/__snapshots__/storyshots-editor.test.js.snap
    A server/zanata-frontend/src/app/editor/actions/activity-action-types.js
    M server/zanata-frontend/src/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/app/editor/actions/review-trans-actions.js
    M server/zanata-frontend/src/app/editor/api/index.js
    M server/zanata-frontend/src/app/editor/components/ActivityFeedItem/ActivityFeedItem.story.js
    M server/zanata-frontend/src/app/editor/components/ActivityFeedItem/index.js
    M server/zanata-frontend/src/app/editor/components/ActivitySelectList/index.js
    R server/zanata-frontend/src/app/editor/components/CommentBox/index.js
    A server/zanata-frontend/src/app/editor/components/CommentBox/index.tsx
    M server/zanata-frontend/src/app/editor/components/TransUnit/index.js
    R server/zanata-frontend/src/app/editor/containers/ActivityTab.js
    A server/zanata-frontend/src/app/editor/containers/ActivityTab.tsx
    M server/zanata-frontend/src/app/editor/containers/GlossaryTab.js
    M server/zanata-frontend/src/app/editor/containers/MainContent.js
    M server/zanata-frontend/src/app/editor/containers/RejectTranslation/index.js
    M server/zanata-frontend/src/app/editor/containers/Sidebar/index.css
    M server/zanata-frontend/src/app/editor/containers/TranslationInfoPanel/index.js
    A server/zanata-frontend/src/app/editor/reducers/activity-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/index.js
    A server/zanata-frontend/src/app/editor/utils/activity-util.ts
    M server/zanata-frontend/src/app/editor/utils/phrase.ts
    M server/zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java

  Log Message:
  -----------
  feat(ZNTA-2297) Editor Activity Panel Backend (#729)

* refactor(ZNTA-2297): conform eslint rules, enable ActivityTab

* feat(ZNTA-2297): implement backend rest service + frontend api for transunit history

* feat(ZNTA-2297): include review comment history in service response

* feat(ZNTA-2297): dispatch transhist api request on select phrase

* feat(ZNTA-2297): implement activity reducer to store translation history state

* feat(ZNTA-2297): init translation history items in parent component, proptypes

* feat(ZNTA-2297): populate activity panel with reviewComments

* fix(ZNTA-2297): provide correct Date obj, use do not render pattern for empty activityitems

* fix(ZNTA-2297): review comment user profile links

* feat(ZNTA-2297): display combined and ordered translation revision and comment history

* feat(ZNTA-2297): make activity and glossary tabs controlled

* test(ZNTA-2297): update storybook, snapshots

* feat(ZNTA-2297): filter selection, update list on key move

* feat(ZNTA-2297): apply filters to activity item list

* perf(ZNTA-2297): only format activity items to be displayed

* feat(ZNTA-2297): retrieve latest history item, refactor server history service to inject handler

* feat(ZNTA-2297): implement activity panel comment box submissions

* test(ZNTA-2297): transunithistory returns bad request on null localeid or transunitid

* fix(ZNTA-2297): gettranslationhistoryresult not populating history

* feat(ZNTA-2297): pass projectSlug, versionSlug to server for validation

* refactor(ZNTA-2297): reuse getTranslationHistory implementation for GWT and React Editors

* refactor(ZNTA-2297): remove unused getReviewComments method

* refactor(ZNTA-2297): ActivityTab to Stateless component, remove unused filter options

* fix(ZNTA-2297): compiler warnings, formatting

* fix(ZNTA-2297): get long intvalue for print

* fix(ZNTA-2297): debug log

* feat(ZNTA-2297): save reviewComment with revision history

* feat(ZNTA-2297): display reviewComment for rejected history items

* test(ZNTA-2297): TranslationData revisionComment equality

* feat(ZNTA-2297): implement activity item copy button

* fix(ZNTA-2297): key action alt+down (move next phrase) triggers transhistory fetch for correct phrase

* fix(ZNTA-2297): use type for CALL_API apiTypes

* refactor(ZNTA-2297): extract checkParams util, callable getTranslationHistory tests

* fix(ZNTA-2297): remove unused GetTranslationHistoryHandler constructors

* refactor(ZNTA-2297): remove gravatar images icons from comments/history items

* refactor(ZNTA-2297): CommentBox to tsx, remove tsignore

* refactor(ZNTA-2297): re-use priority and status types

* refactor(ZNTA-2297): export and use statuses tuple

* refactor(ZNTA-2297): ActivityTab and activity-util to typescript

* refactor(ZNTA-2297): create selectbutton item interface, remove unused imports

* refactor(ZNTA-2297): reinstate propTypes for ActivityTab

* feat(ZNTA-2297): include both HAccount.username and HPerson.name in comments and revision history fetch

* feat(ZNTA-2297): use HPerson.user and HAccount.username to build link and human readible label for comments/revisions

* refactor(ZNTA-2297): more accurate variable names for HPerson.name and HAccount.username

* refactor(ZNTA-2297): move username to reviewcomment constructor

* refactor(ZNTA-2297): swap ReviewComment constructor username, name order

* fix(ZNTA-2297): clear commentbox after post, enforce maxLength

* style(ZNTA-2297): remove excess padding on comment area

* fix(ZNTA-2297): fetch transunithistory after successfully posting new comment

* style(ZNTA-2297): break-word in RevisionBox to contain comments.
fix scrollbar on sidebar going off top of page


  Commit: a46b97548ef1e87db601dd3842755e36d37cfd7a
      https://github.com/zanata/zanata-platform/commit/a46b97548ef1e87db601dd3842755e36d37cfd7a
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2018-03-21 (Wed, 21 Mar 2018)

  Changed paths:
    M server/gwt-editor/pom.xml
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/COPYING
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/README.txt
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/demos/demo_diff.html
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/demos/demo_match.html
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/demos/demo_patch.html
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/javascript/diff_match_patch.js
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/javascript/diff_match_patch_test.html
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/javascript/diff_match_patch_test.js
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/javascript/diff_match_patch_uncompressed.js
    M server/gwt-editor/src/main/webapp/webtrans/Application.xhtml
    M server/services/pom.xml
    M server/services/src/etc/dependencyVersions.groovy
    M server/services/src/main/java/org/zanata/action/ProjectHome.java
    M server/services/src/main/java/org/zanata/servlet/GWTCacheControlFilter.java
    M server/services/src/main/java/org/zanata/util/CommonMarkRenderer.java
    M server/services/src/main/java/org/zanata/util/RunnableEx.java
    A server/services/src/main/java/org/zanata/util/WebJars.kt
    R server/services/src/main/java/org/zanata/util/Webjars.kt
    M server/services/src/test/java/org/zanata/liquibase/custom/MigrateSeamTextToCommonMarkTest.kt
    M server/services/src/test/java/org/zanata/service/impl/ActivityServiceImplTest.java
    M server/services/src/test/java/org/zanata/util/CommonMarkRendererTest.java
    A server/services/src/test/java/org/zanata/util/WebJarsTest.kt
    M server/zanata-war/pom.xml
    M server/zanata-war/src/main/webapp/WEB-INF/layout/project/person-permissions-modal.xhtml
    M server/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml
    M server/zanata-war/src/main/webapp/WEB-INF/template/scripts.xhtml
    M server/zanata-war/src/main/webapp/edit_home_content.xhtml
    R server/zanata-war/src/main/webapp/resources/JavaScript-Templates/2_5_3/README.md
    R server/zanata-war/src/main/webapp/resources/JavaScript-Templates/2_5_3/js/tmpl.min.js
    A server/zanata-war/src/main/webapp/resources/jQuery-File-Upload/README-modified.md
    R server/zanata-war/src/main/webapp/resources/script/crossroads.min.js
    R server/zanata-war/src/main/webapp/resources/script/jquery.typing-0.2.0.min.js
    R server/zanata-war/src/main/webapp/resources/script/jsf-ajax-viewstate-fix.js
    R server/zanata-war/src/main/webapp/resources/script/signals.min.js
    M server/zanata-war/src/main/webapp/resources/zanata/autocomplete.xhtml
    M server/zanata-war/src/main/webapp/resources/zanata/multi-file-upload.xhtml

  Log Message:
  -----------
  chore(ZNTA-2190): use more webjars (#511)

* Add WebJars class to find/load JS files from webjars
* Replace several third party JS files with webjars
* Use fixviewstate from omnifaces
* Improve generator comment for dependencies.properties
* Remove unused diff_match_patch


  Commit: 8c2a003f9beae4443378f589421ac69d0aa23646
      https://github.com/zanata/zanata-platform/commit/8c2a003f9beae4443378f589421ac69d0aa23646
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2018-03-21 (Wed, 21 Mar 2018)

  Changed paths:
    M server/zanata-war/src/main/webapp/WEB-INF/layout/project/people-tab.xhtml
    M server/zanata-war/src/main/webapp/WEB-INF/layout/project/person-permissions-modal.xhtml
    M server/zanata-war/src/main/webapp/resources/zanata/person-permission-entry.xhtml

  Log Message:
  -----------
  Use xmlns:zanata in JSF, not xmlns:z (#758)


  Commit: 4f2172b09df7b4272e5306588e462d6f1fbfe711
      https://github.com/zanata/zanata-platform/commit/4f2172b09df7b4272e5306588e462d6f1fbfe711
  Author: Alex Eng <aeng at redhat.com>
  Date:   2018-03-22 (Thu, 22 Mar 2018)

  Changed paths:
    M server/pom.xml
    M server/zanata-test-war/pom.xml
    M server/zanata-war/pom.xml

  Log Message:
  -----------
  chore: fix deltaspike dependency (#759)


  Commit: 54928300e140d56fdfbda03762f8f4828036f8c0
      https://github.com/zanata/zanata-platform/commit/54928300e140d56fdfbda03762f8f4828036f8c0
  Author: Kathryn Gough <kgough at redhat.com>
  Date:   2018-03-22 (Thu, 22 Mar 2018)

  Changed paths:
    M server/gwt-editor/pom.xml
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/COPYING
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/README.txt
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/demos/demo_diff.html
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/demos/demo_match.html
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/demos/demo_patch.html
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/javascript/diff_match_patch.js
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/javascript/diff_match_patch_test.html
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/javascript/diff_match_patch_test.js
    R server/gwt-editor/src/main/resources/org/zanata/webtrans/public/diff_match_patch/javascript/diff_match_patch_uncompressed.js
    M server/gwt-editor/src/main/webapp/webtrans/Application.xhtml
    M server/gwt-editor/src/test/java/org/zanata/webtrans/client/presenter/TranslationHistoryPresenterTest.java
    M server/gwt-shared/src/main/java/org/zanata/webtrans/shared/model/ReviewComment.java
    M server/gwt-shared/src/main/java/org/zanata/webtrans/shared/model/TransHistoryItem.java
    M server/gwt-shared/src/main/java/org/zanata/webtrans/shared/model/TransUnitUpdateRequest.java
    M server/pom.xml
    M server/services/pom.xml
    M server/services/src/etc/dependencyVersions.groovy
    M server/services/src/main/java/org/zanata/action/ProjectHome.java
    M server/services/src/main/java/org/zanata/rest/editor/dto/TranslationData.java
    A server/services/src/main/java/org/zanata/rest/editor/service/TransUnitHistoryService.java
    M server/services/src/main/java/org/zanata/rest/editor/service/TranslationService.java
    A server/services/src/main/java/org/zanata/rest/editor/service/resource/TransUnitHistoryResource.java
    M server/services/src/main/java/org/zanata/rest/service/RestUtils.java
    M server/services/src/main/java/org/zanata/servlet/GWTCacheControlFilter.java
    M server/services/src/main/java/org/zanata/util/CommonMarkRenderer.java
    M server/services/src/main/java/org/zanata/util/RunnableEx.java
    A server/services/src/main/java/org/zanata/util/WebJars.kt
    R server/services/src/main/java/org/zanata/util/Webjars.kt
    M server/services/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java
    M server/services/src/main/java/org/zanata/webtrans/server/rpc/GetTranslationHistoryHandler.java
    M server/services/src/test/java/org/zanata/liquibase/custom/MigrateSeamTextToCommonMarkTest.kt
    M server/services/src/test/java/org/zanata/rest/editor/dto/TranslationDataTest.java
    A server/services/src/test/java/org/zanata/rest/editor/service/TransUnitHistoryServiceTest.java
    M server/services/src/test/java/org/zanata/service/impl/ActivityServiceImplTest.java
    M server/services/src/test/java/org/zanata/util/CommonMarkRendererTest.java
    A server/services/src/test/java/org/zanata/util/WebJarsTest.kt
    M server/services/src/test/java/org/zanata/webtrans/server/rpc/GetTranslationHistoryHandlerTest.java
    M server/zanata-frontend/src/.storybook-editor/__snapshots__/storyshots-editor.test.js.snap
    A server/zanata-frontend/src/app/editor/actions/activity-action-types.js
    M server/zanata-frontend/src/app/editor/actions/phrases-actions.js
    M server/zanata-frontend/src/app/editor/actions/review-trans-actions.js
    M server/zanata-frontend/src/app/editor/api/index.js
    M server/zanata-frontend/src/app/editor/components/ActivityFeedItem/ActivityFeedItem.story.js
    M server/zanata-frontend/src/app/editor/components/ActivityFeedItem/index.js
    M server/zanata-frontend/src/app/editor/components/ActivitySelectList/index.js
    R server/zanata-frontend/src/app/editor/components/CommentBox/index.js
    A server/zanata-frontend/src/app/editor/components/CommentBox/index.tsx
    M server/zanata-frontend/src/app/editor/components/TransUnit/index.js
    R server/zanata-frontend/src/app/editor/containers/ActivityTab.js
    A server/zanata-frontend/src/app/editor/containers/ActivityTab.tsx
    M server/zanata-frontend/src/app/editor/containers/GlossaryTab.js
    M server/zanata-frontend/src/app/editor/containers/MainContent.js
    M server/zanata-frontend/src/app/editor/containers/RejectTranslation/index.js
    M server/zanata-frontend/src/app/editor/containers/Sidebar/index.css
    M server/zanata-frontend/src/app/editor/containers/TranslationInfoPanel/index.js
    A server/zanata-frontend/src/app/editor/reducers/activity-reducer.js
    M server/zanata-frontend/src/app/editor/reducers/index.js
    A server/zanata-frontend/src/app/editor/utils/activity-util.ts
    M server/zanata-frontend/src/app/editor/utils/phrase.ts
    M server/zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java
    M server/zanata-test-war/pom.xml
    M server/zanata-war/pom.xml
    M server/zanata-war/src/main/webapp/WEB-INF/layout/project/people-tab.xhtml
    M server/zanata-war/src/main/webapp/WEB-INF/layout/project/person-permissions-modal.xhtml
    M server/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml
    M server/zanata-war/src/main/webapp/WEB-INF/template/scripts.xhtml
    M server/zanata-war/src/main/webapp/edit_home_content.xhtml
    R server/zanata-war/src/main/webapp/resources/JavaScript-Templates/2_5_3/README.md
    R server/zanata-war/src/main/webapp/resources/JavaScript-Templates/2_5_3/js/tmpl.min.js
    A server/zanata-war/src/main/webapp/resources/jQuery-File-Upload/README-modified.md
    R server/zanata-war/src/main/webapp/resources/script/crossroads.min.js
    R server/zanata-war/src/main/webapp/resources/script/jquery.typing-0.2.0.min.js
    R server/zanata-war/src/main/webapp/resources/script/jsf-ajax-viewstate-fix.js
    R server/zanata-war/src/main/webapp/resources/script/signals.min.js
    M server/zanata-war/src/main/webapp/resources/zanata/autocomplete.xhtml
    M server/zanata-war/src/main/webapp/resources/zanata/multi-file-upload.xhtml
    M server/zanata-war/src/main/webapp/resources/zanata/person-permission-entry.xhtml

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/master' into ZNTA-2407


  Commit: 5fab46cb784b54e7ba97017135d1f73dce8f12e8
      https://github.com/zanata/zanata-platform/commit/5fab46cb784b54e7ba97017135d1f73dce8f12e8
  Author: kgough <kgough at redhat.com>
  Date:   2018-03-23 (Fri, 23 Mar 2018)

  Changed paths:
    M server/zanata-frontend/src/app/containers/Languages/index.js

  Log Message:
  -----------
  refactor(ZNTA-2407) add ID to fix failing languages tests


Compare: https://github.com/zanata/zanata-platform/compare/2942c3a63cb0...5fab46cb784b

More information about the zanata-commits mailing list