[zanata/zanata-platform] 425a0b: fix(ZNTA-1993): Fix the role manager validation

[GitHub]

  Branch: refs/heads/ZNTA-1993-fix-role-manager
  Home:   https://github.com/zanata/zanata-platform
  Commit: 425a0b588760ca8178132eee3603e014ba356d57
      https://github.com/zanata/zanata-platform/commit/425a0b588760ca8178132eee3603e014ba356d57
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-05-10 (Thu, 10 May 2018)

  Changed paths:
    M server/services/src/main/java/org/zanata/action/RoleAction.java
    M server/services/src/main/java/org/zanata/seam/security/ZanataJpaIdentityStore.java
    A server/services/src/test/java/org/zanata/action/RoleActionTest.java
    M server/zanata-war/src/main/webapp/admin/roledetail.xhtml

  Log Message:
  -----------
  fix(ZNTA-1993): Fix the role manager validation

Prevent empty role name or greater that 255 characters
Prevent role name changes
Prevent overwriting an existing role
Remove users from role before deleting it
Add test



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.