[zanata/zanata-platform] 211786: fix(ZNTA-1993): Update based on review

[GitHub]

  Branch: refs/heads/ZNTA-1993-fix-role-manager
  Home:   https://github.com/zanata/zanata-platform
  Commit: 211786915a2009a0e5d7279cee2da04ee4af457e
      https://github.com/zanata/zanata-platform/commit/211786915a2009a0e5d7279cee2da04ee4af457e
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-05-10 (Thu, 10 May 2018)

  Changed paths:
    M server/services/src/main/java/org/zanata/action/RoleAction.java
    M server/services/src/test/java/org/zanata/action/RoleActionTest.java

  Log Message:
  -----------
  fix(ZNTA-1993): Update based on review

Fix test function names
Move checking logic around to be less heavy handed
Rename stuff for clarity



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.