[zanata/zanata-platform] 262358: fix(ZNTA-1993): Fix the role manager validation (#...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/zanata/zanata-platform
  Commit: 262358c789d9d3a91ddf7a627c03f3e8ed584798
      https://github.com/zanata/zanata-platform/commit/262358c789d9d3a91ddf7a627c03f3e8ed584798
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-05-16 (Wed, 16 May 2018)

  Changed paths:
    M server/services/src/main/java/org/zanata/action/RoleAction.java
    M server/services/src/main/java/org/zanata/seam/security/ZanataJpaIdentityStore.java
    M server/services/src/main/resources/messages.properties
    A server/services/src/test/java/org/zanata/action/RoleActionTest.java
    M server/zanata-war/src/main/webapp/admin/roledetail.xhtml

  Log Message:
  -----------
  fix(ZNTA-1993): Fix the role manager validation (#814)

* fix(ZNTA-1993): Fix the role manager validation
Prevent empty role name or greater that 255 characters
Prevent role name changes
Prevent overwriting an existing role
Remove users from role before deleting it
Add test

* fix(ZNTA-1993): Update based on review
Fix test function names
Move checking logic around to be less heavy handed
Rename stuff for clarity

* fix(ZNTA-1993): add test comment
* fix(ZNTA-1993): fix Codacy errors
* fix(ZNTA-1993): fix FB error
* fix(ZNTA-1993): I18n messages
* fix(ZNTA-1993): fix msgs error and ABC complaint



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.