[zanata/zanata-platform] 2e8f9e: fix(ZNTA-544): incoming email message to plaintext

GitHub noreply at github.com
Thu May 24 08:08:10 UTC 2018


  Branch: refs/heads/ZNTA-544-escape-html-in-messages
  Home:   https://github.com/zanata/zanata-platform
  Commit: 2e8f9ebc23555e20d6b7cc9a4a7b96f61c646b70
      https://github.com/zanata/zanata-platform/commit/2e8f9ebc23555e20d6b7cc9a4a7b96f61c646b70
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M server/services/src/main/java/org/zanata/email/ContactAdminAnonymousEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactAdminEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactLanguageCoordinatorEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/RequestToJoinLanguageEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/RequestToJoinVersionGroupEmailStrategy.java

  Log Message:
  -----------
  fix(ZNTA-544): incoming email message to plaintext

Incoming messages should be plaintext, to avoid malicious links
hidden in anchors


  Commit: e43bb6f059c830ea1a422f7da1d90ceaee60658c
      https://github.com/zanata/zanata-platform/commit/e43bb6f059c830ea1a422f7da1d90ceaee60658c
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M server/services/src/test/java/org/zanata/email/VelocityEmailStrategyTest.java

  Log Message:
  -----------
  fix(ZNTA-544): fix test


  Commit: f4d0bee7bdaf8bd1e107cd2596b322b0acea47e5
      https://github.com/zanata/zanata-platform/commit/f4d0bee7bdaf8bd1e107cd2596b322b0acea47e5
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M server/services/src/main/java/org/zanata/email/ContactAdminAnonymousEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactAdminEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactLanguageCoordinatorEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/RequestToJoinLanguageEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/RequestToJoinVersionGroupEmailStrategy.java
    M server/services/src/main/java/org/zanata/util/HtmlUtil.java
    M server/services/src/test/java/org/zanata/email/VelocityEmailStrategyTest.java

  Log Message:
  -----------
  fix(ZNTA-544): escape and santize instead


  Commit: ccaa8765ac0a31ef95d679c28d4c93918cbf6221
      https://github.com/zanata/zanata-platform/commit/ccaa8765ac0a31ef95d679c28d4c93918cbf6221
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M server/services/src/main/java/org/zanata/email/ContactAdminAnonymousEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactAdminEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactLanguageCoordinatorEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactLanguageTeamMembersEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/DeclineLanguageRequestEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/RequestToJoinLanguageEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/RequestToJoinVersionGroupEmailStrategy.java
    M server/services/src/main/java/org/zanata/util/HtmlUtil.java
    M server/services/src/main/resources/org/zanata/email/templates/decline_language_team_request.vm
    M server/services/src/main/resources/org/zanata/email/templates/email_admin.vm
    M server/services/src/main/resources/org/zanata/email/templates/email_admin_anonymous.vm
    M server/services/src/main/resources/org/zanata/email/templates/email_coordinator.vm
    M server/services/src/main/resources/org/zanata/email/templates/email_language_team_members.vm
    M server/services/src/main/resources/org/zanata/email/templates/email_request_to_join_group.vm
    M server/services/src/main/resources/org/zanata/email/templates/email_request_to_join_language.vm
    M server/services/src/test/java/org/zanata/email/VelocityEmailStrategyTest.java
    M server/services/src/test/java/org/zanata/util/HtmlUtilTest.java

  Log Message:
  -----------
  fix(ZNTA-544): rename parameter to safeHtmlMessage


  Commit: 03bd40ae92162c16d427bcf7d62aa673b9fbe5fb
      https://github.com/zanata/zanata-platform/commit/03bd40ae92162c16d427bcf7d62aa673b9fbe5fb
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M server/services/src/main/java/org/zanata/email/ContactAdminAnonymousEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactAdminEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactLanguageCoordinatorEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/ContactLanguageTeamMembersEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/DeclineLanguageRequestEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/RequestToJoinLanguageEmailStrategy.java
    M server/services/src/main/java/org/zanata/email/RequestToJoinVersionGroupEmailStrategy.java
    M server/services/src/test/java/org/zanata/email/VelocityEmailStrategyTest.java

  Log Message:
  -----------
  fix(ZNTA-544): rename htmlMessage to userMessage


  Commit: 10b26352db7ab0f9ce4705fc2b77d83b707bbae6
      https://github.com/zanata/zanata-platform/commit/10b26352db7ab0f9ce4705fc2b77d83b707bbae6
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M server/services/src/test/java/org/zanata/email/VelocityEmailStrategyTest.java

  Log Message:
  -----------
  fix(ZNTA-544): codacy - explicit scope on variable


Compare: https://github.com/zanata/zanata-platform/compare/1ab7ac777542...10b26352db7a
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the zanata-commits mailing list