[Ansible-service-broker] Automation Broker IRC meeting 4-24-18
Ryan Hallisey
rhallise at redhat.com
Tue Apr 24 14:19:23 UTC 2018
====================================
#asbroker: Automation Broker 4-24-18
====================================
Meeting started by rhallisey at 13:32:55 UTC. The full logs are attached.
Meeting summary
---------------
* Attendance (rhallisey, 13:33:01)
* News (rhallisey, 13:34:00)
* Logging Tip (from jmrodri ) (rhallisey, 13:34:19)
* Bugs/Issue triage (rhallisey, 13:37:18)
* Make sure image tags match releases (rhallisey, 13:37:31)
* LINK:
https://github.com/openshift/ansible-service-broker/issues/896#issuecomment-382373842
(rhallisey, 13:37:38)
* Features (rhallisey, 13:48:03)
* Broker-apb (rhallisey, 13:48:11)
* LINK: https://github.com/openshift/ansible-service-broker/pull/891
(rhallisey, 13:48:16)
* Can we merge some PRs? (rhallisey, 13:50:54)
* LINK: https://github.com/openshift/ansible-service-broker/pull/904
(rhallisey, 13:52:21)
* LINK: https://github.com/openshift/ansible-service-broker/pull/900
(rhallisey, 13:54:15)
* LINK: https://github.com/openshift/ansible-service-broker/pull/897
(rhallisey, 13:55:24)
* LINK: https://github.com/openshift/ansible-service-broker/pull/895
(rhallisey, 13:56:14)
* ACTION: dymurray: send out email to ML about changes to deployment
with #897 (rhallisey, 13:57:59)
* LINK: https://github.com/openshift/ansible-service-broker/pull/887
(rhallisey, 13:58:24)
* LINK: https://github.com/automationbroker/bundle-lib/pull/60
(rhallisey, 13:59:40)
* Open Discussion (rhallisey, 14:01:16)
* APB tool refactor? (rhallisey, 14:01:23)
* ACTION: rhallisey: write up a plan for apb tool v2 (rhallisey,
14:04:19)
Meeting ended at 14:08:11 UTC.
Action Items
------------
* dymurray: send out email to ML about changes to deployment with #897
* rhallisey: write up a plan for apb tool v2
Action Items, by person
-----------------------
* dymurray
* dymurray: send out email to ML about changes to deployment with #897
* rhallisey
* rhallisey: write up a plan for apb tool v2
* **UNASSIGNED**
* (none)
People Present (lines said)
---------------------------
* rhallisey (71)
* jmrodri (45)
* brokerbot (25)
* dymurray (15)
* fabianvf (6)
* ernelson (5)
* shurley (5)
* dzager (4)
* mhrivnak (3)
* maleck13 (1)
Generated by `MeetBot`_ 0.1.4
.. _`MeetBot`: http://wiki.debian.org/MeetBot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/ansible-service-broker/attachments/20180424/b035bd68/attachment.htm>
-------------- next part --------------
13:32:55 <rhallisey> #startmeeting Automation Broker 4-24-18
13:32:55 <brokerbot> Meeting started Tue Apr 24 13:32:55 2018 UTC. The chair is rhallisey. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:32:55 <brokerbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
13:32:55 <brokerbot> The meeting name has been set to 'automation_broker_4-24-18'
13:32:55 <brokerbot> rhallisey: startmeeting Meeting Agenda https://docs.google.com/document/d/1Mj7bVYJ8NK-TwU_mxeZLprmBBZZ-xOq-Hg4CiD3E6pM/edit?usp=sharing
13:33:01 <rhallisey> #topic Attendance
13:33:01 <brokerbot> rhallisey: topic
13:33:03 <rhallisey> o/
13:33:10 <rhallisey> what's up folks
13:33:21 <ernelson> heyo
13:33:38 <mhrivnak> hi!
13:34:00 <rhallisey> #topic News
13:34:00 <brokerbot> rhallisey: topic
13:34:01 <dymurray> hello!
13:34:19 <rhallisey> #info Logging Tip (from jmrodri )
13:34:19 <brokerbot> rhallisey: info
13:34:39 <jmrodri> sorry
13:35:09 <jmrodri> yes if you are logging in the broker or bundle-lib, and using the substitutions like %s %v use the *f version of the logging method
13:35:22 <jmrodri> for example, Debugf("Hello %s", name)
13:35:58 <rhallisey> good tip
13:36:10 <jmrodri> go-logging pkg is more forgiving but logrus isn't. We had a few log messages that looked like: "Hello %s how are you?foo"
13:36:21 <jmrodri> I fixed them all in the broker and bundle-lib (PRs were posted).
13:36:41 <jmrodri> for reviewers be on the lookout for those in upcoming PRs.
13:36:49 <jmrodri> that's all.
13:36:59 <rhallisey> thanks jmrodri
13:37:18 <rhallisey> #topic Bugs/Issue triage
13:37:18 <brokerbot> rhallisey: topic
13:37:31 <rhallisey> #info Make sure image tags match releases
13:37:31 <brokerbot> rhallisey: info
13:37:38 <rhallisey> #link https://github.com/openshift/ansible-service-broker/issues/896#issuecomment-382373842
13:37:38 <brokerbot> rhallisey: link
13:38:01 <rhallisey> I saw this yesterday we may have had a conversation about this in the past
13:38:32 <rhallisey> but in the openshift-ansible releases, we using the latest tag
13:38:54 <rhallisey> I haven't looked in our own repo if we also do that
13:39:41 <rhallisey> what are folks thoughts on addressing this? We want to make sure scripts always have the right tag
13:40:36 <rhallisey> or maybe this is a one time thing
13:41:37 <rhallisey> no thoughts? I guess we'll have to keep an eye out for it
13:41:45 <dzager> well there is the broker-apb with tagged images for latest, release-1.0, and release-1.1 to provision the correct broker
13:41:54 <jmrodri> I think the tags are important.
13:42:02 <dzager> but there is also changes in each of the branches to use the correct image based on the branch
13:42:13 <jmrodri> We've had to make quite a few updates to scripts to match particular tags. Especially in release branches.
13:42:28 <rhallisey> that's what I wanted to check dzager. Want to make sure we're following.
13:42:30 <jmrodri> I think dzager and others have covered the release branches by now
13:42:32 <rhallisey> it may just be this one case
13:42:48 <jmrodri> rhallisey: I think the issue you linked too was a recent case
13:42:56 <jmrodri> that needed attention.
13:43:11 <dzager> I like the idea of having the broker-apb as the source for installing the broker with the notable exception of openshift-ansible until we update it to use the broker-apb ;)
13:43:25 <fabianvf> rhallisey: for 3.7 there was actually resistance from the openshift-ansible team to locking the origin version down
13:43:36 <fabianvf> I proposed it back when they branched
13:44:03 <fabianvf> I don't remember why they didn't want to, I don't think I really understood at the time either
13:44:36 <rhallisey> fabianvf, I was talking about the broker version in openshift-ansible. Is that what you meant?
13:44:45 <rhallisey> I mean the apb version
13:44:46 <rhallisey> *
13:44:50 <rhallisey> tag*
13:44:52 <fabianvf> Yes
13:45:04 <fabianvf> Oh, no then
13:45:27 <rhallisey> fabianvf, https://github.com/openshift/openshift-ansible/pull/8089
13:45:40 <rhallisey> fabianvf, would that be accepted?
13:46:33 <rhallisey> fabianvf, we can worry about it after the meeting
13:46:41 <rhallisey> let's sync after
13:46:52 <fabianvf> rhallisey: I think it's generated enough pain that we can work past pushback if it's still there
13:46:59 <rhallisey> did anyone else have other issues to bring up?
13:47:01 <rhallisey> fabianvf, ack
13:47:53 <rhallisey> fabianvf, we'll have to fix 3.9 too
13:48:03 <rhallisey> #topic Features
13:48:03 <brokerbot> rhallisey: topic
13:48:11 <rhallisey> #info Broker-apb
13:48:11 <brokerbot> rhallisey: info
13:48:16 <rhallisey> #link https://github.com/openshift/ansible-service-broker/pull/891
13:48:16 <brokerbot> rhallisey: link
13:48:48 <rhallisey> dzager, this looked good to go from my perspective. Is there anything else you know is needed?
13:49:15 <dzager> I was waiting on shurley since I updated based on his comments
13:49:18 <jmrodri> rhallisey: shurley marked it as X
13:49:30 <jmrodri> shurley: any issues with the above PR?
13:49:45 <jmrodri> dzager: might have to bonk him on the head :)
13:49:49 <shurley> nope
13:49:51 <jmrodri> shurley: +1
13:49:52 <jmrodri> hahaha
13:49:56 <shurley> visack
13:50:45 <rhallisey> this goes into the next topic
13:50:54 <rhallisey> #topic Can we merge some PRs?
13:50:54 <brokerbot> rhallisey: topic
13:51:14 * rhallisey merges #891
13:51:46 <rhallisey> do we want to go through open PRs that have approvals an merge them if they're ready?
13:52:00 <jmrodri> yeah let's do that
13:52:12 <rhallisey> ok I'll start linking them
13:52:13 <jmrodri> if they need more review, that's fine
13:52:21 <rhallisey> #link https://github.com/openshift/ansible-service-broker/pull/904
13:52:21 <brokerbot> rhallisey: link
13:52:38 <jmrodri> rhallisey: that broker travis for some reason
13:52:51 <jmrodri> I'm looking to see what it is. OTher than that, looks like it has at least 2 approvals.
13:52:52 <shurley> has anyone looked into that?
13:53:05 <jmrodri> shurley: I'm looking into it now, didn't realize it was busted :)
13:53:22 <rhallisey> error: unable to recognize "/tmp/broker-resource.yaml": no matches for kind "ClusterServiceBroker" in version "servicecatalog.k8s.io/v1beta1"
13:53:25 <jmrodri> rhallisey: once I get green on travis, I'll merge. It has 2 acks already.
13:53:26 <ernelson> I briefly looked into travis failures yesterday, I didn't find anything of note aside from it timing out from deprovisions
13:53:30 <shurley> I mean it's been three weeks since I fixed it last so right on time TBH
13:53:35 <ernelson> I reran a few times and it got green
13:54:01 <jmrodri> ernelson: sounds like a timing issue.
13:54:13 <rhallisey> next up
13:54:15 <rhallisey> #link https://github.com/openshift/ansible-service-broker/pull/900
13:54:15 <brokerbot> rhallisey: link
13:54:20 <ernelson> yeah dunno what the problem was
13:54:42 <jmrodri> ah dzager wanted more protection on that PR
13:54:57 <jmrodri> I'll close for now. I don't have time to fix it this week.
13:55:02 <rhallisey> jmrodri, ok
13:55:12 <jmrodri> closed. I'm the only one using that feature :)
13:55:24 <rhallisey> #link https://github.com/openshift/ansible-service-broker/pull/897
13:55:24 <brokerbot> rhallisey: link
13:55:46 <jmrodri> that has plenty of acks
13:55:49 <rhallisey> this has beaucoup acks
13:55:52 <jmrodri> I'll merge it.
13:56:14 <rhallisey> #link https://github.com/openshift/ansible-service-broker/pull/895
13:56:14 <brokerbot> rhallisey: link
13:56:14 <jmrodri> rhallisey: ernelson done
13:56:26 <rhallisey> no review yet on this one
13:56:31 <dymurray> I think we should send out an email to explain the change in deployment with this merge
13:56:38 <dymurray> Pretty big PR
13:56:41 <rhallisey> dymurray, which one?
13:56:42 <jmrodri> rhallisey: added myself to that PR
13:56:49 <rhallisey> thanks jmrodri
13:56:52 <dymurray> #8976
13:56:52 <brokerbot> dymurray: Error: "8976" is not a valid command.
13:56:56 <dymurray> 897**
13:56:57 <jmrodri> dymurray: the dashboard one?
13:57:01 <dymurray> Yes
13:57:10 <dymurray> I can send it out
13:57:15 <jmrodri> dymurray: thanks
13:57:20 <rhallisey> good idea dymurray
13:57:36 <jmrodri> rhallisey: can you add an action for dymurray then?
13:57:44 * jmrodri not sure if anyone can add that to the bot :)
13:57:59 <rhallisey> #action dymurray: send out email to ML about changes to deployment with #897
13:57:59 <brokerbot> rhallisey: action
13:58:14 <rhallisey> jmrodri, I need to change that... for some reason you need to identify with it
13:58:24 <rhallisey> #link https://github.com/openshift/ansible-service-broker/pull/887
13:58:24 <brokerbot> rhallisey: link
13:58:31 <rhallisey> this has no reviews yet
13:58:47 <rhallisey> pretty simple change
13:59:40 <rhallisey> #link https://github.com/automationbroker/bundle-lib/pull/60
13:59:40 <brokerbot> rhallisey: link
13:59:58 <rhallisey> state support inc
14:00:11 <rhallisey> I'm going to add myself to that one
14:00:32 <rhallisey> any more PRs folks want to review?
14:00:48 <jmrodri> I think that was it. My other one has a review pending updates from me
14:01:16 <rhallisey> #topic Open Discussion
14:01:16 <brokerbot> rhallisey: topic
14:01:23 <rhallisey> #info APB tool refactor?
14:01:23 <brokerbot> rhallisey: info
14:01:44 <rhallisey> I added this. I was wondering if folks have thought about this at all?
14:01:59 <rhallisey> if we have thought about a time frame or next steps?
14:02:19 <dymurray> rhallisey, it sounds like plans are to block out time from next sprint for v2 of the tool
14:02:30 <dymurray> Maybe end of this sprint if we have time. Just research/planning
14:02:44 <dymurray> Try to get a prototype off of bundle-lib
14:03:10 <mhrivnak> I'd suggest an important next step is to scope out what it should and should not do. It sounds like that thinking has evolved since the first version of the tool.
14:03:19 <jmrodri> mhrivnak: +1
14:03:24 <rhallisey> mhrivnak, agreed
14:03:53 <dymurray> +1
14:03:58 <rhallisey> I can take the action item of a proposal.
14:04:18 <jmrodri> if we're using bundle-lib, that sounds like a golang app then. Unless there's a way to make bundle-lib a C library that can be pulled into python (that sounds hairy)
14:04:19 <rhallisey> #action rhallisey: write up a plan for apb tool v2
14:04:19 <brokerbot> rhallisey: action
14:04:43 <mhrivnak> It is possible to turn golang into a python library, but not likely advisable for this case.
14:05:02 <dymurray> I think that the intention would be moving the CLI tool to golang based on our previous meetings around this
14:05:15 <jmrodri> mhrivnak: yeah, I don't think I'd move in that direction :) but the curious side of me took over hehehe
14:05:15 <dymurray> rhallisey, I'd like to help with that proposal if you'll take it
14:05:16 <shurley> personally I think it is 100x easier to distribute a binary then deal with python
14:05:22 <jmrodri> dymurray: +1
14:05:31 <maleck13> shurley: +1
14:05:46 <jmrodri> shurley: not in the RHEL world :)
14:05:52 <jmrodri> but I'm good with golang
14:06:10 <rhallisey> dymurray, sure. What I can do is write a sketch of it and get together offline to mold it
14:06:12 <dymurray> We've had some good discussions in the past as a team around this just need to assess where bundle-lib is at in its current state and what steps we need to take next
14:06:19 <dymurray> rhallisey, +1 perfect thanks
14:06:50 <jmrodri> rhallisey: dymurray +1
14:06:58 <rhallisey> that's all I had for that topic. Are there any more open discussion items?
14:07:10 <jmrodri> I don't have anything
14:07:21 <ernelson> jmrodri: there are options to produce a C style binary that python can consume, so at least we aren't closing doors with go
14:07:36 <jmrodri> ernelson: cool
14:08:07 <rhallisey> ok folks, thanks for coming
14:08:11 <rhallisey> #endmeeting
-------------- next part --------------
====================================
#asbroker: Automation Broker 4-24-18
====================================
Meeting started by rhallisey at 13:32:55 UTC. The full logs are
available at asbroker/2018/asbroker.2018-04-24-13.32.log.html .
Meeting summary
---------------
* Attendance (rhallisey, 13:33:01)
* News (rhallisey, 13:34:00)
* Logging Tip (from jmrodri ) (rhallisey, 13:34:19)
* Bugs/Issue triage (rhallisey, 13:37:18)
* Make sure image tags match releases (rhallisey, 13:37:31)
* LINK:
https://github.com/openshift/ansible-service-broker/issues/896#issuecomment-382373842
(rhallisey, 13:37:38)
* Features (rhallisey, 13:48:03)
* Broker-apb (rhallisey, 13:48:11)
* LINK: https://github.com/openshift/ansible-service-broker/pull/891
(rhallisey, 13:48:16)
* Can we merge some PRs? (rhallisey, 13:50:54)
* LINK: https://github.com/openshift/ansible-service-broker/pull/904
(rhallisey, 13:52:21)
* LINK: https://github.com/openshift/ansible-service-broker/pull/900
(rhallisey, 13:54:15)
* LINK: https://github.com/openshift/ansible-service-broker/pull/897
(rhallisey, 13:55:24)
* LINK: https://github.com/openshift/ansible-service-broker/pull/895
(rhallisey, 13:56:14)
* ACTION: dymurray: send out email to ML about changes to deployment
with #897 (rhallisey, 13:57:59)
* LINK: https://github.com/openshift/ansible-service-broker/pull/887
(rhallisey, 13:58:24)
* LINK: https://github.com/automationbroker/bundle-lib/pull/60
(rhallisey, 13:59:40)
* Open Discussion (rhallisey, 14:01:16)
* APB tool refactor? (rhallisey, 14:01:23)
* ACTION: rhallisey: write up a plan for apb tool v2 (rhallisey,
14:04:19)
Meeting ended at 14:08:11 UTC.
Action Items
------------
* dymurray: send out email to ML about changes to deployment with #897
* rhallisey: write up a plan for apb tool v2
Action Items, by person
-----------------------
* dymurray
* dymurray: send out email to ML about changes to deployment with #897
* rhallisey
* rhallisey: write up a plan for apb tool v2
* **UNASSIGNED**
* (none)
People Present (lines said)
---------------------------
* rhallisey (71)
* jmrodri (45)
* brokerbot (25)
* dymurray (15)
* fabianvf (6)
* ernelson (5)
* shurley (5)
* dzager (4)
* mhrivnak (3)
* maleck13 (1)
Generated by `MeetBot`_ 0.1.4
.. _`MeetBot`: http://wiki.debian.org/MeetBot
More information about the Ansible-service-broker
mailing list