[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12] PciBusDxe: Separation of the PCI device registration and start

Ni, Ray ray.ni at intel.com
Thu Dec 19 01:34:25 UTC 2019


> >
> > 2 minor comments:
> > 1. StartPciRootPortsOnBridge()
> >      Can it be renamed to EnablePciDevicesOnBridge()?
> >      Because it basically calls PciIo.Attribute() to enable the devices. And I am
> not
> > sure the enable only applies to PCI root ports. There could be PCI devices
> behind
> > P2P bridge.
> It enables only Type 1 PCI devices (Root Port, PCIe-to-PCI Bridge, PCIe switch
> upstream/downstream ports), and no endpoint (Type 0) devices.

I see. Then how about EnablePciBridges()?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52391): https://edk2.groups.io/g/devel/message/52391
Mute This Topic: https://groups.io/mt/55155883/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list