[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12] PciBusDxe: Separation of the PCI device registration and start

[Javeed, Ashraf]

> -----Original Message-----
> From: Ni, Ray <ray.ni at intel.com>
> Sent: Thursday, December 19, 2019 7:04 AM
> To: Javeed, Ashraf <ashraf.javeed at intel.com>; devel at edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A <hao.a.wu at intel.com>
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12]
> PciBusDxe: Separation of the PCI device registration and start
> 
> > >
> > > 2 minor comments:
> > > 1. StartPciRootPortsOnBridge()
> > >      Can it be renamed to EnablePciDevicesOnBridge()?
> > >      Because it basically calls PciIo.Attribute() to enable the
> > > devices. And I am
> > not
> > > sure the enable only applies to PCI root ports. There could be PCI
> > > devices
> > behind
> > > P2P bridge.
> > It enables only Type 1 PCI devices (Root Port, PCIe-to-PCI Bridge,
> > PCIe switch upstream/downstream ports), and no endpoint (Type 0) devices.
> 
> I see. Then how about EnablePciBridges()?
This will do.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52397): https://edk2.groups.io/g/devel/message/52397
Mute This Topic: https://groups.io/mt/55155883/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-