[edk2-devel] [Patch v10 2/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

[Laszlo Ersek]

On 02/05/20 17:18, Kinney, Michael D wrote:
> Jian,
> 
> I agree.  If the PCD type is anything but FixedAtBuild,
> the compiler can not optimize away the unused BaseCryptLib
> functions.
> 
> I think the best solution is to limit this PCD to only
> FixedAtBuild.

I agree that that technically solves the problem, and it also seems like
a justifiable design decision.

> Thank you for noticing this issue Laszlo!

Whenever I pull from master, I tend to skim the new commits quickly in
"gitk". Nothing resembling real patch review, I just have a few
"favorite" :) areas that stand out to me on occasion (not always, of
course).

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53834): https://edk2.groups.io/g/devel/message/53834
Mute This Topic: https://groups.io/mt/70960524/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-