[edk2-devel] [PATCH 06/11] OvmfPkg/LsiScsiDxe: Report Targets and LUNs

[Laszlo Ersek]

On 07/08/20 04:34, Gary Lin wrote:
> On Tue, Jul 07, 2020 at 11:04:21AM +0200, Laszlo Ersek wrote:
>> On 07/01/20 06:04, Gary Lin wrote:

>>> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
>>> index 65bb2bb0eb4c..ae7d1d648d22 100644
>>> --- a/OvmfPkg/OvmfPkg.dec
>>> +++ b/OvmfPkg/OvmfPkg.dec
>>> @@ -174,6 +174,11 @@ [PcdsFixedAtBuild]
>>>    ## Microseconds to stall between polling for MptScsi request result
>>>    gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x40
>>>  
>>> +  ## Set the *inclusive* number of targets and LUNs that LsiScsi exposes for
>>> +  #  scan by ScsiBusDxe.
>>> +  gUefiOvmfPkgTokenSpaceGuid.PcdLsiScsiMaxTargetLimit|7|UINT8|0x3b
>>> +  gUefiOvmfPkgTokenSpaceGuid.PcdLsiScsiMaxLunLimit|0|UINT8|0x3c
>>> +
>>>    gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogBase|0x0|UINT32|0x8
>>>    gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogSize|0x0|UINT32|0x9
>>>    gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFirmwareFdSize|0x0|UINT32|0xa
>>>
>>
>> Commit 093cceaf79b5 ("OvmfPkg/MptScsiDxe: Report targets and one LUN",
>> 2020-05-05) introduced PcdMptScsiMaxTargetLimit with token value 0x39.
>> That was OK.
>>
>> Commit 505812ae1d2d ("OvmfPkg/MptScsiDxe: Implement the PassThru
>> method", 2020-05-05) then introduced PcdMptScsiStallPerPollUsec with
>> token value 0x40. That was not OK -- but I missed it. (The token value
>> should have been 0x3a; as 0x39 is not succeeded by 0x40 but by 0x3a.)
>>
>> Token value 0x3a remains unused at this point.
>>
>> (5) So please introduce the new PCDs with token values 0x3a and 0x3b, to
>> keep the token space dense.
>>
> I actually was thinking about making PcdMptScsiStallPerPollUsec 0x3a in
> another patch. Since it's not related to LsiScsi, I didn't do it in this
> series. Sounds like you prefer to keeping 0x40 for
> PcdMptScsiStallPerPollUsec?

If you can post a separate patch for changing the
PcdMptScsiStallPerPollUsec token value to 0x3a, that's best!

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#62239): https://edk2.groups.io/g/devel/message/62239
Mute This Topic: https://groups.io/mt/75228763/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-