[edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset

[Abner Chang]

Thanks Maciej.
Abner

Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: Rabeda, Maciej <maciej.rabeda at linux.intel.com>
Sent: Friday, October 9, 2020, 5:39 PM
To: devel at edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
Cc: Wu Jiaxin; Fu Siyuan; Wang, Nickle (HPS SW)
Subject: Re: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset

Merged:
https://github.com/tianocore/edk2/commit/5df413119ec80cb462bf9c888ef5574f8ce8ae2e
https://github.com/tianocore/edk2/pull/995

On 08-Oct-20 18:17, Maciej Rabeda wrote:
> Hi Abner,
>
> Waiting for review on a different patch on NetworkPkg, else CI likely
> fires in my face when I try to integrate yours.
>
> https://edk2.groups.io/g/devel/message/65833
>
> Thanks,
> Maciej
>
> On 08-Oct-20 15:50, Abner Chang wrote:
>> Hi Maciej,
>> Could you please help to merge this patch? Thanks!
>> Abner
>>
>>> -----Original Message-----
>>> From: Rabeda, Maciej [mailto:maciej.rabeda at linux.intel.com]
>>> Sent: Tuesday, September 29, 2020 9:47 PM
>>> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang at hpe.com>;
>>> devel at edk2.groups.io
>>> Cc: Wu Jiaxin <jiaxin.wu at intel.com>; Fu Siyuan <siyuan.fu at intel.com>;
>>> Wang, Nickle (HPS SW) <nickle.wang at hpe.com>
>>> Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared
>>> when reset
>>>
>>> Reviewed-by: Maciej Rabeda <maciej.rabeda at linux.intel.com>
>>>
>>> On 28-Sep-20 08:29, Abner Chang wrote:
>>>> BZ #2909,
>>>> INVALID URI REMOVED
>>>> e.org_show-5Fbug.cgi-3Fid-
>>> 3D2909&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
>>> SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=gVilLut38Vw51w0YX
>>> bkL2XI7A
>>>> ieZI7M-
>>> u7_bYls4zQo&s=eavHqEkeSVmQnn5EYDmq9TnEyjp8MS3_hdpPDgG9hSY&e=
>>>> When Http->Configure() is invoked with HttpConfigData set to NULL to
>>>> reset the EFI HTTP instance, TLS child instance is destroyed but
>>>> HttpInstance->TlsChildHandle is not set to NULL. After reconfiguring
>>>> HTTP through Http->Configure() and sending the HTTP request to HTTPS
>>>> URL, TLS child instance is not recreated because
>>>> HttpInstance->TlsChildHandle is not NULL.
>>>>
>>>> Signed-off-by: Abner Chang <abner.chang at hpe.com>
>>>>
>>>> Cc: Maciej Rabeda <maciej.rabeda at linux.intel.com>
>>>> Cc: Wu Jiaxin <jiaxin.wu at intel.com>
>>>> Cc: Fu Siyuan <siyuan.fu at intel.com>
>>>> Cc: Nickle Wang <nickle.wang at hpe.com>
>>>> ---
>>>>    NetworkPkg/HttpDxe/HttpProto.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/NetworkPkg/HttpDxe/HttpProto.c
>>>> b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7db5a726
>>> 100644
>>>> --- a/NetworkPkg/HttpDxe/HttpProto.c
>>>> +++ b/NetworkPkg/HttpDxe/HttpProto.c
>>>> @@ -873,6 +873,7 @@ HttpCleanProtocol (
>>>>        // Destroy the TLS instance.
>>>>        //
>>>>        HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb,
>>>> HttpInstance->TlsChildHandle);
>>>> +    HttpInstance->TlsChildHandle = NULL;
>>>>      }
>>>>
>>>>      if (HttpInstance->Tcp4ChildHandle != NULL) {
>>
>>
>>
>>
>>
>
>
>
> 
>
>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66061): https://edk2.groups.io/g/devel/message/66061
Mute This Topic: https://groups.io/mt/77169386/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20201009/814ab897/attachment.htm>