[edk2-devel] CI test on copyright

[Bret Barkelew via groups.io]

Try removing the extra line between “SPDX” and “##”.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang at hpe.com>
Sent: Thursday, October 15, 2020 9:32 AM
To: Bret Barkelew<mailto:Bret.Barkelew at microsoft.com>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan at microsoft.com>
Subject: [EXTERNAL] RE: CI test on copyright


## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
#
##

Or you can check the PR,
https://github.com/tianocore/edk2/pull/1019<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1019&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C76b2a39f7041477ec48508d87127ed6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637383763585626301%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8pY6rGL6Z65oTSCyUGOA%2BsjmQSiwbbQiVJ%2B9LJhGAAM%3D&reserved=0>

Abner

From: Bret Barkelew [mailto:Bret.Barkelew at microsoft.com]
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang at hpe.com>; devel at edk2.groups.io
Cc: Sean Brogan <sean.brogan at microsoft.com>
Subject: RE: CI test on copyright

Can you share the entire copyright header? In my experience, It’s actually complaining about one of the ‘#’ or ‘/*’ tags.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang at hpe.com>
Sent: Thursday, October 15, 2020 9:21 AM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>
Cc: Bret Barkelew<mailto:Bret.Barkelew at microsoft.com>; Sean Brogan<mailto:sean.brogan at microsoft.com>
Subject: [EXTERNAL] CI test on copyright

Hi Sean and Bret,
I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

[cid:image001.png at 01D6A353.D58FEA40]


The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

Any idea on this?
Abner




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66278): https://edk2.groups.io/g/devel/message/66278
Mute This Topic: https://groups.io/mt/77531759/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20201015/fadf7da8/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 18194 bytes
Desc: image001.png
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20201015/fadf7da8/attachment.png>