Re: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI

[Laszlo Ersek]

Hi Liming, Shenglei,

On 09/02/20 11:36, gaoliming wrote:
> Because the fix for ECC tool has been merged, I also request to catch this
> change for stable202008 tag. 

I'm OK with that, given that this patch modifies .pytool (that is, CI)
--  in other words, I'm OK because the patch affects our workflow only,
and doesn't really affect the edk2 codebase itself.

(Put differently, downstream parties that fork edk2 at
edk2-stable202008, or rebase their current forks to edk2-stable202008,
cannot be affected by this change in any way.)

However, I suggest a different approach for the patch itself (the end
result will be the same, code-wise). Please start the patch by running:

$ git revert d4e0b9607c9a

and then please extend the commit message. It should be clear from the
commit log (subject and first paragraph) that this patch is a revert.

Furthermore, TianoCore#2904 is in RESOLVED|FIXED status already. (And
even the code comment, from the original patch, says: "need to be
removed *after* BZ2904 is fixed" [emphasis mine] -- so this new patch,
the revert, is not expected to be a part of BZ2904.)

So I suggest opening a new TianoCore BZ as well, making it *dependent*
on 2904. And the revert should reference the new BZ.

Again, I'm fine with merging this patch before the stable tag, I'd just
like the BZ reference and the revert statement to be clean.

Thanks!
Laszlo

>> -----邮件原件-----
>> 发件人: bounce+27952+64967+4905953+8761045 at groups.io
>> <bounce+27952+64967+4905953+8761045 at groups.io> 代表 gaoliming
>> 发送时间: 2020年9月2日 17:06
>> 收件人: 'Shenglei Zhang' <shenglei.zhang at intel.com>; devel at edk2.groups.io
>> 抄送: 'Sean Brogan' <sean.brogan at microsoft.com>; 'Bret Barkelew'
>> <Bret.Barkelew at microsoft.com>; 'Michael D Kinney'
>> <michael.d.kinney at intel.com>
>> 主题: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error
>> code 10014 for open CI
>>
>> Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>
>>
>> Thanks
>> Liming
>>> -----邮件原件-----
>>> 发件人: Shenglei Zhang <shenglei.zhang at intel.com>
>>> 发送时间: 2020年9月2日 16:38
>>> 收件人: devel at edk2.groups.io
>>> 抄送: Sean Brogan <sean.brogan at microsoft.com>; Bret Barkelew
>>> <Bret.Barkelew at microsoft.com>; Michael D Kinney
>>> <michael.d.kinney at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>
>>> 主题: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open
>> CI
>>>
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
>>> As the false positive issue whose error code is 10014 has been
>>> fixed, we need to re-enable it on open CI.
>>>
>>> Cc: Sean Brogan <sean.brogan at microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>
>>> Cc: Michael D Kinney <michael.d.kinney at intel.com>
>>> Cc: Liming Gao <gaoliming at byosoft.com.cn>
>>> Signed-off-by: Shenglei Zhang <shenglei.zhang at intel.com>
>>> ---
>>>  .pytool/Plugin/EccCheck/EccCheck.py | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
>>> b/.pytool/Plugin/EccCheck/EccCheck.py
>>> index 3eaad0bf5623..eee1ff7a77b5 100644
>>> --- a/.pytool/Plugin/EccCheck/EccCheck.py
>>> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
>>> @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
>>>                               "10011",
>>>                               "10012",
>>>                               "10013",
>>> -                             "10014", #need to be removed after
>>> BZ2904 is fixed
>>>                               "10015",
>>>                               "10016",
>>>                               "10017",
>>> --
>>> 2.18.0.windows.1
>>
>>
>>
>>
>>
> 
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64972): https://edk2.groups.io/g/devel/message/64972
Mute This Topic: https://groups.io/mt/76578692/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-