Re: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI

[Laszlo Ersek]

(request for Mike below)

On 09/02/20 13:08, Laszlo Ersek wrote:
> Hi Liming, Shenglei,
> 
> On 09/02/20 11:36, gaoliming wrote:
>> Because the fix for ECC tool has been merged, I also request to catch this
>> change for stable202008 tag. 
> 
> I'm OK with that, given that this patch modifies .pytool (that is, CI)
> --  in other words, I'm OK because the patch affects our workflow only,
> and doesn't really affect the edk2 codebase itself.
> 
> (Put differently, downstream parties that fork edk2 at
> edk2-stable202008, or rebase their current forks to edk2-stable202008,
> cannot be affected by this change in any way.)
> 
> However, I suggest a different approach for the patch itself (the end
> result will be the same, code-wise). Please start the patch by running:
> 
> $ git revert d4e0b9607c9a
> 
> and then please extend the commit message. It should be clear from the
> commit log (subject and first paragraph) that this patch is a revert.
> 
> Furthermore, TianoCore#2904 is in RESOLVED|FIXED status already. (And
> even the code comment, from the original patch, says: "need to be
> removed *after* BZ2904 is fixed" [emphasis mine] -- so this new patch,
> the revert, is not expected to be a part of BZ2904.)
> 
> So I suggest opening a new TianoCore BZ as well, making it *dependent*
> on 2904. And the revert should reference the new BZ.
> 
> Again, I'm fine with merging this patch before the stable tag, I'd just
> like the BZ reference and the revert statement to be clean.

... also wanted to mention that #2904 is a BaseTools BZ, but this revert
patch is for .pytool (CI).

In fact: Mike, can we please add ".pytool" or maybe "Core CI" to the
Package list in the TianoCore Bugzilla installation? The original BZ for
commit d4e0b9607c9a -- i.e., the one that's now being reverted -- says
"Package: N/A", and that's not really helpful.

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64973): https://edk2.groups.io/g/devel/message/64973
Mute This Topic: https://groups.io/mt/76578692/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-