[edk2-devel] 回复: [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load option in the first boot

[gaoliming]

Zhiguang:
  I see QuarkPlatformPkg uses PCD gQuarkPlatformTokenSpaceGuid.PcdBootState
to decide whether current boot is the first boot or not. 
  This PCD is configured as DynamicHiiPcd, and be set in
Platform\Intel\QuarkPlatformPkg\Library\PlatformBootManagerLib\PlatformBootM
anager.c

  Can you use the same solution in Intel BoardModulePkg?

Thanks
Liming
> -----邮件原件-----
> 发件人: Ni, Ray <ray.ni at intel.com>
> 发送时间: 2021年3月10日 17:56
> 收件人: Liu, Zhiguang <zhiguang.liu at intel.com>; devel at edk2.groups.io
> 抄送: Dong, Eric <eric.dong at intel.com>; Liming Gao
> <gaoliming at byosoft.com.cn>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Agyeman, Prince
> <prince.agyeman at intel.com>; Gao, Zhichao <zhichao.gao at intel.com>
> 主题: RE: [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load option
> in the first boot
> 
> 1. DataSIze should be set to sizeof (BOOLEAN) before calling GetVariable()
> 
> > +      Status = gRT->GetVariable (
> > +                      L"IsFirstBoot",
> 
> 2. Can you please define a macro in this C file for IsFirstBoot string?
> e.g.: #define IS_FIRST_BOOT_VAR_NAME L"IsFirstBoot"
> 
> > +      if (IsFirstBoot == TRUE) {
> 
> 3. Please remove "== TRUE". Just use "If (IsFirstBoot)".
> 
> > +                        L"IsFirstBoot",
> 4. Please use the macro defined as above.
> 
> >
> > +                        &gEfiCallerIdGuid,
> >
> > +                        EFI_VARIABLE_NON_VOLATILE |
> > EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS,
> 
> 5. Please remove "EFI_VARIABLE_RUNTIME_ACCESS".
> 
> > +                        1,
> 6. Please use sizeof (BOOLEAN) instead of "1".





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72749): https://edk2.groups.io/g/devel/message/72749
Mute This Topic: https://groups.io/mt/81339950/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-