回复: [edk2-devel] [Patch edk2-stable202111] NetworkPkg: Fix invalid pointer for DNS response token on error

[gaoliming]

I suggest to merge this fix for the stable tag 202111. This fix is low risk.


 

Thanks

Liming

发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Wu, Jiaxin
发送时间: 2021年11月25日 9:37
收件人: Anbazhagan, Baraneedharan <anbazhagan at hp.com>; devel at edk2.groups.io
抄送: maciej.rabeda at linux.intel.com; Fu, Siyuan <siyuan.fu at intel.com>
主题: Re: [edk2-devel] NetworkPkg: Fix invalid pointer for DNS response
token on error

 

Reviewed-by: Wu Jiaxin <jiaxin.wu at intel.com <mailto:jiaxin.wu at intel.com> >

 

 

 

From: Anbazhagan, Baraneedharan <anbazhagan at hp.com
<mailto:anbazhagan at hp.com> > 
Sent: Thursday, November 25, 2021 9:28 AM
To: devel at edk2.groups.io <mailto:devel at edk2.groups.io> 
Cc: maciej.rabeda at linux.intel.com <mailto:maciej.rabeda at linux.intel.com> ;
Wu, Jiaxin <jiaxin.wu at intel.com <mailto:jiaxin.wu at intel.com> >; Fu, Siyuan
<siyuan.fu at intel.com <mailto:siyuan.fu at intel.com> >
Subject: RE: NetworkPkg: Fix invalid pointer for DNS response token on error

 

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3719

 

Token->RspData.H2AData is de-allocated on error but it is not

set to NULL. HTTP module attempts to free again and cause assert.

 

Signed-off-by: Baraneedharan Anbazhagan anbazhagan at hp.com
<mailto:anbazhagan at hp.com> 

---

NetworkPkg/DnsDxe/DnsImpl.c | 2 ++

1 file changed, 2 insertions(+)

 

diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c

index 2edcb280ac..78a56f2b56 100644

--- a/NetworkPkg/DnsDxe/DnsImpl.c

+++ b/NetworkPkg/DnsDxe/DnsImpl.c

@@ -1700,6 +1700,7 @@ ON_EXIT:

           }

 

           FreePool (Dns4TokenEntry->Token->RspData.H2AData);

+          Dns4TokenEntry->Token->RspData.H2AData = NULL;

         }

       }

     }

@@ -1731,6 +1732,7 @@ ON_EXIT:

           }

 

           FreePool (Dns6TokenEntry->Token->RspData.H2AData);

+          Dns6TokenEntry->Token->RspData.H2AData = NULL;

         }

       }

     }

-- 

2.33.0.windows.2

 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84072): https://edk2.groups.io/g/devel/message/84072
Mute This Topic: https://groups.io/mt/87294818/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20211125/86e86d66/attachment.htm>