[edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

[RichardHo [何明忠] via groups.io]

Hi Michael,

Thanks for your response. I will fixed it next.

Thanks,
Richard

-----Original Message-----
From: Michael Brown <mcb30 at ipxe.org>
Sent: 2022年12月2日 6:09 PM
To: devel at edk2.groups.io; Richard Ho (何明忠) <RichardHo at ami.com>
Cc: Andrew Fish <afish at apple.com>; Leif Lindholm <quic_llindhol at quicinc.com>; Michael D Kinney <michael.d.kinney at intel.com>; Michael Kubacki <michael.kubacki at microsoft.com>; Zhiguang Liu <zhiguang.liu at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>; Tony Lo (羅金松) <TonyLo at ami.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

On 03/10/2022 10:26, RichardHo [何明忠] via groups.io wrote:
> diff --git a/UsbNetworkPkg/NetworkCommon/DriverBinding.h b/UsbNetworkPkg/NetworkCommon/DriverBinding.h
> new file mode 100644
> index 0000000000..29f1f967f5
> --- /dev/null
> +++ b/UsbNetworkPkg/NetworkCommon/DriverBinding.h

> +VOID
> +UndiApiEntry (
> +  IN  UINT64  Cdb
> +  );

Needs an EFIAPI modifier, i.e.

VOID
EFIAPI
UndiApiEntry (
   IN  UINT64  Cdb
   );

to avoid runtime failures when using a non-Microsoft compiler.

> diff --git a/UsbNetworkPkg/NetworkCommon/PxeFunction.c b/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> new file mode 100644
> index 0000000000..f6505f7018
> --- /dev/null
> +++ b/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> +/**
> +  UNDI API table entry.
> +
> +  @param[in]  Cdb  A pointer to the command descriptor block.
> +
> +**/
> +VOID
> +UndiApiEntry (
> +  IN  UINT64  Cdb
> +  )

As above:

VOID
EFIAPI
UndiApiEntry (
   IN  UINT64  Cdb
   )

Thanks,

Michael
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96891): https://edk2.groups.io/g/devel/message/96891
Mute This Topic: https://groups.io/mt/94086820/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-