[edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Hi Richard,
Attach the changes for GCC build for your reference.

Regards,
Abner

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Michael
> Brown via groups.io
> Sent: Friday, December 2, 2022 6:09 PM
> To: devel at edk2.groups.io; richardho at ami.com
> Cc: Andrew Fish <afish at apple.com>; Leif Lindholm
> <quic_llindhol at quicinc.com>; Michael D Kinney
> <michael.d.kinney at intel.com>; Michael Kubacki
> <michael.kubacki at microsoft.com>; Zhiguang Liu <zhiguang.liu at intel.com>;
> Liming Gao <gaoliming at byosoft.com.cn>; TonyLo [羅金松]
> <TonyLo at ami.com>
> Subject: Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB
> RNDIS devices support
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On 03/10/2022 10:26, RichardHo [何明忠] via groups.io wrote:
> > diff --git a/UsbNetworkPkg/NetworkCommon/DriverBinding.h
> b/UsbNetworkPkg/NetworkCommon/DriverBinding.h
> > new file mode 100644
> > index 0000000000..29f1f967f5
> > --- /dev/null
> > +++ b/UsbNetworkPkg/NetworkCommon/DriverBinding.h
>
> > +VOID
> > +UndiApiEntry (
> > +  IN  UINT64  Cdb
> > +  );
>
> Needs an EFIAPI modifier, i.e.
>
> VOID
> EFIAPI
> UndiApiEntry (
>    IN  UINT64  Cdb
>    );
>
> to avoid runtime failures when using a non-Microsoft compiler.
>
> > diff --git a/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> b/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> > new file mode 100644
> > index 0000000000..f6505f7018
> > --- /dev/null
> > +++ b/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> > +/**
> > +  UNDI API table entry.
> > +
> > +  @param[in]  Cdb  A pointer to the command descriptor block.
> > +
> > +**/
> > +VOID
> > +UndiApiEntry (
> > +  IN  UINT64  Cdb
> > +  )
>
> As above:
>
> VOID
> EFIAPI
> UndiApiEntry (
>    IN  UINT64  Cdb
>    )
>
> Thanks,
>
> Michael
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#96889):
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F96889&data=05%7C01%7Cab
> ner.chang%40amd.com%7C39e68bbdf1f5417b461f08dad44d43f7%7C3dd8961
> fe4884e608e11a82d994e183d%7C0%7C0%7C638055725573799145%7CUnkno
> wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1
> haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zfUyf7AWaaUt6
> 6DOzqLVPqQtlRQedKYTlip1GkTFibM%3D&reserved=0
> Mute This Topic:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgrou
> ps.io%2Fmt%2F94086820%2F7039027&data=05%7C01%7Cabner.chang%
> 40amd.com%7C39e68bbdf1f5417b461f08dad44d43f7%7C3dd8961fe4884e608
> e11a82d994e183d%7C0%7C0%7C638055725573799145%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C3000%7C%7C%7C&sdata=9vuQ0ASsAZE9Yp0PfaISJDUd
> 7rrkX3lKIcPW4oFWkds%3D&reserved=0
> Group Owner: devel+owner at edk2.groups.io
> Unsubscribe:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Funsub&data=05%7C01%7Cabner.chang%
> 40amd.com%7C39e68bbdf1f5417b461f08dad44d43f7%7C3dd8961fe4884e608
> e11a82d994e183d%7C0%7C0%7C638055725573799145%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C3000%7C%7C%7C&sdata=Jz4uZ%2FTBRryfR68pXATPirQ
> wj%2BlO0I1h1LUQ%2Flkdm1Q%3D&reserved=0
> [abner.chang at amd.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-GCC-build-errors.patch
Type: application/octet-stream
Size: 6695 bytes
Desc: 0001-Fix-GCC-build-errors.patch
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20221202/d61a3899/attachment.obj>