[edk2-devel] [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

[Yao, Jiewen]

This seems a big incompatible change.

I feel this is weird to hardcode the configuration here.

How the OVMF binary knows it runs on a new CloudHv or old CloudHv?

Can we have a mechanism to detect the data at runtime? E.g. read some PCI register ?




From: Boeuf, Sebastien <sebastien.boeuf at intel.com>
Sent: Tuesday, September 6, 2022 10:08 PM
To: Yao, Jiewen <jiewen.yao at intel.com>
Cc: Justen, Jordan L <jordan.l.justen at intel.com>; kraxel at redhat.com; devel at edk2.groups.io
Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

Hi Jiewen,

Do you think this could be merged?

Thanks,
Sebastien
________________________________
From: Boeuf, Sebastien <sebastien.boeuf at intel.com<mailto:sebastien.boeuf at intel.com>>
Sent: Friday, August 19, 2022 11:59 AM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>>
Cc: Yao, Jiewen <jiewen.yao at intel.com<mailto:jiewen.yao at intel.com>>; Justen, Jordan L <jordan.l.justen at intel.com<mailto:jordan.l.justen at intel.com>>; kraxel at redhat.com<mailto:kraxel at redhat.com> <kraxel at redhat.com<mailto:kraxel at redhat.com>>; Boeuf, Sebastien <sebastien.boeuf at intel.com<mailto:sebastien.boeuf at intel.com>>
Subject: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

From: Sebastien Boeuf <sebastien.boeuf at intel.com<mailto:sebastien.boeuf at intel.com>>

Both ACPI shutdown and ACPI PM timer devices has been moved to different
port addresses in the latest version of Cloud Hypervisor. These changes
need to be reflected on the OVMF firmware.

Acked-by: Gerd Hoffmann <kraxel at redhat.com<mailto:kraxel at redhat.com>>
Signed-off-by: Sebastien Boeuf <sebastien.boeuf at intel.com<mailto:sebastien.boeuf at intel.com>>
---
 OvmfPkg/Include/IndustryStandard/CloudHv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/OvmfPkg/Include/IndustryStandard/CloudHv.h b/OvmfPkg/Include/IndustryStandard/CloudHv.h
index d31ecc9eec..527c236f48 100644
--- a/OvmfPkg/Include/IndustryStandard/CloudHv.h
+++ b/OvmfPkg/Include/IndustryStandard/CloudHv.h
@@ -16,12 +16,12 @@
 //

 // ACPI timer address

 //

-#define CLOUDHV_ACPI_TIMER_IO_ADDRESS  0xb008

+#define CLOUDHV_ACPI_TIMER_IO_ADDRESS  0x0608



 //

 // ACPI shutdown device address

 //

-#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS  0x03c0

+#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS  0x0600



 //

 // 32-bit MMIO memory hole base address

--
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93228): https://edk2.groups.io/g/devel/message/93228
Mute This Topic: https://groups.io/mt/93121228/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20220906/d8e72e42/attachment-0001.htm>