[edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32
Sheng Lean Tan
sheng.tan at 9elements.com
Tue Apr 4 12:46:02 UTC 2023
Hi Rebecca/ Marvin,
Patrick has filed it as a separate patch email here
https://edk2.groups.io/g/devel/message/102168
However the email still group them together.
It is because he could not reproduce any issue anymore that was seen on 2nd
patch (could be that Rebecca already fixed it).
Could you help to review and get this merged?
Thanks,
Sheng
On Thu, 30 Mar 2023 at 10:05, Marvin Häuser <mhaeuser at posteo.de> wrote:
> Hi Lean,
>
> I don’t think individual patches from a series are merged generally. Your
> 2/3 has open concerns from both Liming and myself.
>
> Best regards,
> Marvin
>
> On 30. Mar 2023, at 09:31, Lean Sheng Tan <sheng.tan at 9elements.com> wrote:
>
>
> HI Liming,
> If no further concern, would you mind to help get this patch merged?
> Thanks!
>
> Best Regards,
> *Lean Sheng Tan*
>
>
> On Tue, 28 Mar 2023 at 07:42, gaoliming via groups.io <gaoliming=
> byosoft.com.cn at groups.io> wrote:
>
>> Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>
>>
>> > -----邮件原件-----
>> > 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Patrick
>> > Rudolph
>> > 发送时间: 2023年3月17日 22:06
>> > 抄送: devel at edk2.groups.io; guo.dong at intel.com; gua.guo at intel.com;
>> > james.lu at intel.com; ray.ni at intel.com; mhaeuser at posteo.de;
>> > ardb at kernel.org
>> > 主题: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using
>> > CLANGDWARF_IA32
>> >
>> > The clang toolchain might default to fPIE/fPIC, which prevents
>> > lld from linking the objects into a binary.
>> >
>> > Specify -fno-pie -fno-pic as done on GCC to fix linking.
>> >
>> > Test:
>> > Building the Universal Payload using the command
>> > 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually
>> > works.
>> >
>> > Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
>> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4356
>> > ---
>> > BaseTools/Conf/tools_def.template | 14 +++++++-------
>> > 1 file changed, 7 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/BaseTools/Conf/tools_def.template
>> > b/BaseTools/Conf/tools_def.template
>> > index 471eb67c0c..9b59bd75c3 100755
>> > --- a/BaseTools/Conf/tools_def.template
>> > +++ b/BaseTools/Conf/tools_def.template
>> > @@ -2888,7 +2888,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
>> > = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22
>> > *_CLANGDWARF_IA32_RC_PATH =
>> > DEF(CLANGDWARF_IA32_PREFIX)llvm-rc
>> >
>> >
>> >
>> > *_CLANGDWARF_IA32_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
>> > -m32 -fno-lto DEF(CLANG38_IA32_TARGET)
>> >
>> > -*_CLANGDWARF_IA32_ASLDLINK_FLAGS =
>> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld
>> >
>> > +*_CLANGDWARF_IA32_ASLDLINK_FLAGS =
>> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld
>> > -no-pie
>> >
>> > *_CLANGDWARF_IA32_ASM_FLAGS = DEF(GCC5_ASM_FLAGS)
>> > -m32 -march=i386 DEF(CLANG38_IA32_TARGET)
>> >
>> > *_CLANGDWARF_IA32_RC_FLAGS =
>> > DEF(GCC_IA32_RC_FLAGS)
>> >
>> > *_CLANGDWARF_IA32_OBJCOPY_FLAGS =
>> >
>> > @@ -2897,17 +2897,17 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
>> > = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22
>> > *_CLANGDWARF_IA32_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS)
>> > DEF(CLANG38_IA32_TARGET)
>> >
>> > *_CLANGDWARF_IA32_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS)
>> > DEF(CLANG38_IA32_TARGET)
>> >
>> >
>> >
>> > -DEBUG_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586
>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>> >
>> > +DEBUG_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586
>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>> >
>> > DEBUG_CLANGDWARF_IA32_DLINK_FLAGS =
>> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
>> > -Wl,--oformat,elf32-i386
>> >
>> > -DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld
>> >
>> > +DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie
>> >
>> >
>> >
>> > -RELEASE_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586
>> > DEF(CLANG38_IA32_TARGET) -malign-double
>> >
>> > +RELEASE_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586
>> > DEF(CLANG38_IA32_TARGET) -malign-double
>> >
>> > RELEASE_CLANGDWARF_IA32_DLINK_FLAGS =
>> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
>> > -Wl,--oformat,elf32-i386
>> >
>> > -RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld
>> >
>> > +RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie
>> >
>> >
>> >
>> > -NOOPT_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=i586
>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>> >
>> > +NOOPT_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -O0 -march=i586
>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>> >
>> > NOOPT_CLANGDWARF_IA32_DLINK_FLAGS =
>> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_i386
>> > -Wl,--oformat,elf32-i386
>> >
>> > -NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=lld
>> >
>> > +NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=lld -no-pie
>> >
>> >
>> >
>> > ##########################
>> >
>> > # CLANGDWARF X64 definitions
>> >
>> > --
>> > 2.39.1
>> >
>> >
>> >
>> > -=-=-=-=-=-=
>> > Groups.io Links: You receive all messages sent to this group.
>> > View/Reply Online (#101340):
>> > https://edk2.groups.io/g/devel/message/101340
>> > Mute This Topic: https://groups.io/mt/97673648/4905953
>> > Group Owner: devel+owner at edk2.groups.io
>> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
>> > [gaoliming at byosoft.com.cn]
>> > -=-=-=-=-=-=
>> >
>>
>>
>>
>>
>>
>>
>>
>>
>>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102482): https://edk2.groups.io/g/devel/message/102482
Mute This Topic: https://groups.io/mt/97945955/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230404/246daca0/attachment-0001.htm>
More information about the edk2-devel-archive
mailing list