[edk2-devel] [PATCH v3 1/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis: Add USB RNDIS devices support

Wu, Hao A hao.a.wu at intel.com
Thu Jun 8 06:22:38 UTC 2023


Thanks.

Please help to:
* Update the DSC file in the last commit (patch 3/3 of the series). Patch 1/3 only adds NetworkCommon & UsbRndis, this will cause build failure in certain scenario.
* Add the Bugzilla link information in the commit log message.

With above handled:
Acked-by: Hao A Wu <hao.a.wu at intel.com>

Also sorry for a question:
  MdeModulePkg/Bus/Usb/UsbNetwork/NetworkCommon/NetworkCommon.inf
  MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbCdcEcm.inf
  MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm/UsbCdcNcm.inf
  MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis/UsbRndis.inf
These drivers follow the UEFI Driver Model (install EFI Driver Binding Protocol), why they are listed as DXE_DRIVER instead of UEFI_DRIVER in the INF files?

Best Regards,
Hao Wu

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of
> RichardHo [ºÎÃ÷ÖÒ] via groups.io
> Sent: Thursday, June 8, 2023 11:48 AM
> To: Wu, Hao A <hao.a.wu at intel.com>; devel at edk2.groups.io
> Cc: Andrew Fish <afish at apple.com>; Leif Lindholm
> <quic_llindhol at quicinc.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>; Michael Kubacki
> <mikuback at linux.microsoft.com>; Liu, Zhiguang <zhiguang.liu at intel.com>;
> Gao, Liming <gaoliming at byosoft.com.cn>; Ni, Ray <ray.ni at intel.com>; Tinh
> Nguyen <tinhnguyen at os.amperecomputing.com>; Rebecca Cran
> <rebecca at bsdio.com>; Tony Lo (Á_½ðËÉ) <TonyLo at ami.com>
> Subject: Re: [edk2-devel] [PATCH v3 1/3]
> MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis: Add USB RNDIS devices
> support
> 
> Hi Hao Wu,
> 
> I have created it in 2023-05-07.
> https://bugzilla.tianocore.org/show_bug.cgi?id=4451
> 
> Thanks,
> Richard


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105916): https://edk2.groups.io/g/devel/message/105916
Mute This Topic: https://groups.io/mt/99398816/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list