[edk2-devel] [PATCH v3 1/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis: Add USB RNDIS devices support

[RichardHo [何明忠] via groups.io]

Hi Hao Wu,

I will provide V4 for below next.

#1 Modify DSC file in patch 3/3
#2 add Acked-by: Hao A Wu <hao.a.wu at intel.com>
#3 modify DXE_DRIVER to UEFI_DRIVER

Thanks,
Richard

-----Original Message-----
From: Wu, Hao A <hao.a.wu at intel.com>
Sent: 2023年6月8日 2:23 PM
To: devel at edk2.groups.io; Richard Ho (何明忠) <RichardHo at ami.com>
Cc: Andrew Fish <afish at apple.com>; Leif Lindholm <quic_llindhol at quicinc.com>; Kinney, Michael D <michael.d.kinney at intel.com>; Michael Kubacki <mikuback at linux.microsoft.com>; Liu, Zhiguang <zhiguang.liu at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Ni, Ray <ray.ni at intel.com>; Tinh Nguyen <tinhnguyen at os.amperecomputing.com>; Rebecca Cran <rebecca at bsdio.com>; Tony Lo (羅金松) <TonyLo at ami.com>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v3 1/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis: Add USB RNDIS devices support


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Thanks.

Please help to:
* Update the DSC file in the last commit (patch 3/3 of the series). Patch 1/3 only adds NetworkCommon & UsbRndis, this will cause build failure in certain scenario.
* Add the Bugzilla link information in the commit log message.

With above handled:
Acked-by: Hao A Wu <hao.a.wu at intel.com>

Also sorry for a question:
  MdeModulePkg/Bus/Usb/UsbNetwork/NetworkCommon/NetworkCommon.inf
  MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbCdcEcm.inf
  MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm/UsbCdcNcm.inf
  MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis/UsbRndis.inf
These drivers follow the UEFI Driver Model (install EFI Driver Binding Protocol), why they are listed as DXE_DRIVER instead of UEFI_DRIVER in the INF files?

Best Regards,
Hao Wu

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of
> RichardHo [何明忠] via groups.io
> Sent: Thursday, June 8, 2023 11:48 AM
> To: Wu, Hao A <hao.a.wu at intel.com>; devel at edk2.groups.io
> Cc: Andrew Fish <afish at apple.com>; Leif Lindholm
> <quic_llindhol at quicinc.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>; Michael Kubacki
> <mikuback at linux.microsoft.com>; Liu, Zhiguang
> <zhiguang.liu at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Ni,
> Ray <ray.ni at intel.com>; Tinh Nguyen
> <tinhnguyen at os.amperecomputing.com>; Rebecca Cran <rebecca at bsdio.com>;
> Tony Lo (羅金松) <TonyLo at ami.com>
> Subject: Re: [edk2-devel] [PATCH v3 1/3]
> MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis: Add USB RNDIS devices
> support
>
> Hi Hao Wu,
>
> I have created it in 2023-05-07.
> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D4451&data=05%7C01%7Crichardho
> %40ami.com%7C11d0ff9e04ff4e340c8f08db67e8d64d%7C27e97857e15f486cb58e86
> c2b3040f93%7C1%7C0%7C638218021967302562%7CUnknown%7CTWFpbGZsb3d8eyJWIj
> oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%7C&sdata=pJpb7xUHSkbdpzAYeBcBkCHc5RzLYfa4puTyc9d8wxY%3D&reserved=0
>
> Thanks,
> Richard
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105966): https://edk2.groups.io/g/devel/message/105966
Mute This Topic: https://groups.io/mt/99398816/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-