[Freeipa-devel] [PATCH] basic connection pool and user search

[Kevin McCarthy]

Rob Crittenden wrote:
> Kevin McCarthy wrote:
>> Rob Crittenden wrote:
>>> diff -r 491d5b50aabb -r 90e45700faff ipa-server/xmlrpc-server/funcs.py
>>> --- a/ipa-server/xmlrpc-server/funcs.py	Fri Aug 10 08:15:23 2007 -0400
>>> +++ b/ipa-server/xmlrpc-server/funcs.py	Mon Aug 13 16:41:38 2007 -0400
>> [snip]
>>> @@ -210,12 +248,24 @@ class IPAServer:
>>>          """Return a list containing a User object for each
>>>          existing user.
>>>          """
>>> +        global _LDAPPool
>>> +    +        if opts:
>>               ^^^
>> this seems to be using a variable opts that isn't defined in
>> get_all_users().  did I miss a patch?
>
> No, I missed one :-(
>
> diff -r d914656e4f87 -r fc81940f81a1 ipa-server/xmlrpc-server/funcs.py
> --- a/ipa-server/xmlrpc-server/funcs.py Tue Aug 14 17:22:05 2007 -0400
> +++ b/ipa-server/xmlrpc-server/funcs.py Thu Aug 16 10:26:34 2007 -0400
> @@ -244,7 +244,7 @@ class IPAServer:
>
>          return fields
>
> -    def get_all_users (self):
> +    def get_all_users (self, args=None, opts=None):
>          """Return a list containing a User object for each
>          existing user.
>          """

Looks good - note both patches need to be committed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070816/576222fc/attachment.bin>