[Freeipa-devel] [PATCH] more flexible group membership querying

[Rob Crittenden]

Simo Sorce wrote:
> On Thu, 2008-03-27 at 08:44 -0400, Rob Crittenden wrote:
>> Simo Sorce wrote:
>>> On Wed, 2008-03-26 at 11:37 -0400, Rob Crittenden wrote:
>>>> +            if e.dn not in real_members:
>>>> +                if membertype == 2:
>>>> +                    entries.append(self.convert_entry(e))
>>>> +            else:
>>>> +                if membertype == 1:
>>>> +                    entries.append(self.convert_entry(e))
>>>> +
>>> Shouldn't the second be a removal ?
>>> You defined 1 as: "only direct members" so indirect ones should be
>>> removed right ?
>> No, the list starts out as empty. If they are not a real/direct member 
>> and we're only looking for the inherited/indirect members then they get 
>> appended to the list in the first case.
>>
>> Otherwise if the are in the list and those are what we're looking for, 
>> we append them.
> 
> Right I see it so clearly now (/me takes mental note not to review
> patches ion the evening or when tired anyway :/)
> 
> So this is an ack.
> 
> Simo.
> 

pushed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080327/4f3fa62a/attachment.bin>