[Freeipa-devel] [PATCH] Fixes for nsssrv service

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Simo Sorce wrote:
> On Wed, 2009-04-01 at 12:36 -0400, Stephen Gallagher wrote:
> 
>> Nack
>>
>> Copy-paste error in sysdb.h
>> - -#define SYSDB_GRPW_ATTRS {SYSDB_NAME, SYSDB_LAST_UPDATE, \
>> +#define SYSDB_GRPW_ATTRS {SYSDB_NAME, SYSDB_UIDNUM, \
>> +                          SYSDB_LAST_UPDATE, \
>>                            "objectClass", \
>>                            NULL}
>>
>> Should be SYSDB_GIDNUM, shouldn't it?
> 
> No, this is the list of attributes when we search for group members (ie
> users).
> 
>> Also, if we're testing for invalid UID/GID, wouldn't '<= 0' be more
>> accurate than '== 0'?
> 
> No, the variables used are all unsigned.
> 
>> Nitpick:
>> +        DEBUG(1, ("The '%s' library does not provides the "
>> +                  "_nss_XXX_initgroups_dyn function!\n"
>> +                  "initgroups will be slow as it will require "
>> +                  "full groups enumeration!\n", libname));
>>
>> Should read:
>> The '%s' library does not provide the _nss_XXX_initgroups_dyn function!
>> initgroups will be slow as it will require full group enumeration.
>>
>>
>> Nitpick:
>> Testing for
>> if ((info->id_min && (gid < info->id_min))
>> is redundant. We only need to test
>> if(gid < info->id_min)
> 
> right but it is harmless, and conveys the point that it is an "optional"
> test :)
> 
> Simo.
> 

Ack

- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAknTsswACgkQeiVVYja6o6PdkQCfc5yOFH3hrTS5bulUnfxjIcXN
qosAnAkyZsrWpjf93GreZad2hBGfMHfg
=71lA
-----END PGP SIGNATURE-----