[Freeipa-devel] [PATCH] Fixes for nsssrv service

[Simo Sorce]

On Wed, 2009-04-01 at 14:30 -0400, Stephen Gallagher wrote:
> Simo Sorce wrote:
> > On Wed, 2009-04-01 at 12:36 -0400, Stephen Gallagher wrote:
> > 
> >> Nack
> >>
> >> Copy-paste error in sysdb.h
> >> - -#define SYSDB_GRPW_ATTRS {SYSDB_NAME, SYSDB_LAST_UPDATE, \
> >> +#define SYSDB_GRPW_ATTRS {SYSDB_NAME, SYSDB_UIDNUM, \
> >> +                          SYSDB_LAST_UPDATE, \
> >>                            "objectClass", \
> >>                            NULL}
> >>
> >> Should be SYSDB_GIDNUM, shouldn't it?
> > 
> > No, this is the list of attributes when we search for group members
> (ie
> > users).
> > 
> >> Also, if we're testing for invalid UID/GID, wouldn't '<= 0' be more
> >> accurate than '== 0'?
> > 
> > No, the variables used are all unsigned.
> > 
> >> Nitpick:
> >> +        DEBUG(1, ("The '%s' library does not provides the "
> >> +                  "_nss_XXX_initgroups_dyn function!\n"
> >> +                  "initgroups will be slow as it will require "
> >> +                  "full groups enumeration!\n", libname));
> >>
> >> Should read:
> >> The '%s' library does not provide the _nss_XXX_initgroups_dyn
> function!
> >> initgroups will be slow as it will require full group enumeration.
> >>
> >>
> >> Nitpick:
> >> Testing for
> >> if ((info->id_min && (gid < info->id_min))
> >> is redundant. We only need to test
> >> if(gid < info->id_min)
> > 
> > right but it is harmless, and conveys the point that it is an
> "optional"
> > test :)
> > 
> > Simo.
> > 
> 
> Ack


pushed

-- 
Simo Sorce * Red Hat, Inc * New York