[Freeipa-devel] [PATCH] sssd: style and const fixes for common/

Stephen Gallagher sgallagh at redhat.com
Tue Apr 7 12:31:41 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Simo Sorce wrote:
> The recently pushed common/ code does not conform to sssd style
> guidelines.
> 
> The first patch address the style issue.
> Note: I gave authorship to Dmitri as this are just sytle fixes, and I
> don't want to snatch authorship of the code (man git-annotate if you
> don't know what I am talking about :)
> 
> The second patch fixes const warnings, it make strings that the
> functions should not touch const.
> I strongly recommend this second patch as it is important from a public
> API to give guarantees to applications about what it is going to touch
> and keeps us honest too, avoid touching string that come from user
> applications by mistake.
> 
> Simo.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


Ack to both, but please fix the whitespace when you commit it.

- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAknbR6oACgkQeiVVYja6o6MuuQCfc3VxL/BqiRaSBlHHE2063Hoc
LVIAn3lAkXzw59PSUEHK0wlMi2VLjx+K
=/s5C
-----END PGP SIGNATURE-----




More information about the Freeipa-devel mailing list