[Freeipa-devel] [PATCH] sssd: style and const fixes for common/

Simo Sorce ssorce at redhat.com
Tue Apr 7 18:30:21 UTC 2009


On Tue, 2009-04-07 at 08:31 -0400, Stephen Gallagher wrote:
> Simo Sorce wrote:
> > The recently pushed common/ code does not conform to sssd style
> > guidelines.
> > 
> > The first patch address the style issue.
> > Note: I gave authorship to Dmitri as this are just sytle fixes, and
> I
> > don't want to snatch authorship of the code (man git-annotate if you
> > don't know what I am talking about :)
> > 
> > The second patch fixes const warnings, it make strings that the
> > functions should not touch const.
> > I strongly recommend this second patch as it is important from a
> public
> > API to give guarantees to applications about what it is going to
> touch
> > and keeps us honest too, avoid touching string that come from user
> > applications by mistake.

> Ack to both, but please fix the whitespace when you commit it.

Pushed with one minor change in the first patch discussed on the phone.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list