[Freeipa-devel] Patch for the INI parser. Ceanup. Prep for INI validation.

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dmitri Pal wrote:
> Hi,
> 
>    INI parser. Cleanup. Prep for INI validation.
>      This patch addresses several issues:
>    a) Cleaning unit test to match coding standard
>    b) Replace tabs with spaces - I do not know where they came
>    but there were some.
>    c) Allowing to read file and keep aside a collection
>    of K-V pairs where key is the key in the INI file and value is the
>    line number on which line the key appears.
>    d) There will be different kinds of errors so
>    error printing function was abstracted.
>    g) Placeholders for other printing functions have been introduced.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Nack

Do not include so many different changes in a single patch. Of note,
never include formatting changes alongside functional changes. This
needs to be broken up into at least two patches, one for the formatting
and the other for the functional changes.

There is no need to internationalize the empty string. It's a waste of
gettext macros.

I am morally opposed to the use of inline in a public API, but I can
live with it.



- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAknnWEUACgkQeiVVYja6o6MIRACgmWDiwkiY218KSSB5sJQERaEO
crgAn1PsZlL5QrTgvAQV42QKq+86e+u3
=JB5u
-----END PGP SIGNATURE-----