[Freeipa-devel] Patch for the INI parser. Ceanup. Prep for INI validation.

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Stephen Gallagher wrote:
> Dmitri Pal wrote:
>> Hi,
> 
>>    INI parser. Cleanup. Prep for INI validation.
>>      This patch addresses several issues:
>>    a) Cleaning unit test to match coding standard
>>    b) Replace tabs with spaces - I do not know where they came
>>    but there were some.
>>    c) Allowing to read file and keep aside a collection
>>    of K-V pairs where key is the key in the INI file and value is the
>>    line number on which line the key appears.
>>    d) There will be different kinds of errors so
>>    error printing function was abstracted.
>>    g) Placeholders for other printing functions have been introduced.
> 
> 
> 
>> ------------------------------------------------------------------------
> 
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> Nack
> 
> Do not include so many different changes in a single patch. Of note,
> never include formatting changes alongside functional changes. This
> needs to be broken up into at least two patches, one for the formatting
> and the other for the functional changes.
> 
> There is no need to internationalize the empty string. It's a waste of
> gettext macros.
> 
> I am morally opposed to the use of inline in a public API, but I can
> live with it.
> 
> 
> 

After several off-list discussions, I'm going to push this patch, and
Dmitri will follow up with some additional fixes.

Highlights: his copy of git is broken, so breaking the patch in two is
non-trivial. The strings are placeholders, so it's fine to
internationalize them. Inline may be removed in a subsequent patch.

Ack and pushed.

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel at redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAknnmi0ACgkQeiVVYja6o6NbqQCePr9CGtc/C3y+yF5kkAw/Ua5+
nqkAoJuYl5E3WIJFgt2s6+tI/il1zcY3
=vtdC
-----END PGP SIGNATURE-----