[Freeipa-devel] Re: [PATCHES] Add HBAC plugin port to new LDAP backend.

[David O'Brien]

Simo Sorce wrote:
> On Wed, 2009-06-17 at 09:04 +1000, David O'Brien wrote:
>   
>> Rob Crittenden wrote:
>>     
>>> Pavel Zuna wrote:
>>>       
>>>> I think this plugin is a good demonstration of what the new base 
>>>> classes for plugins using LDAP can do. The old plugin was 
>>>> considerebaly longer and a lot more complex.
>>>>
>>>> Patch 0015: Add GeneralisedTime parameter type.
>>>>         
>>> Not sure if it is a Queens english vs American english but shouldn't 
>>> generalized be spelled with a 'z' instead of an 's' at the end?
>>>       
>> All RH documentation uses US English - and consequently "z" here - so it 
>> would be nice if the docstrings, parameter names, etc., followed suit 
>> wherever possible.
>>     
>
> This referes to an LDAP attribute type, we need to use the same name
> used in the schema/RFCs even if it was spelled generalixed :-)
>
> (And yes I think it is GeneralizedTime)
>
> Simo.
>
>   
Yes, thought as much, hence the "wherever possible". We have enough 
"discussions", thankfully with minimal blood-letting, over spelling and 
style issues just in doc without getting too involved in the code side 
as well  :-)

-- 

David O'Brien
IPA Content Author
Red Hat Asia Pacific
+61 7 3514 8189

"The most valuable of all talents is that of never using two words when
one will do."
   Thomas Jefferson