[Freeipa-devel] [PATCH][SSSD] Allow the use of custom CFLAGS on the make command line

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/19/2009 09:22 AM, Simo Sorce wrote:
> On Fri, 2009-06-19 at 07:14 -0400, Stephen Gallagher wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 06/18/2009 04:01 PM, Simo Sorce wrote:
>>> On Thu, 2009-06-18 at 11:32 -0400, Stephen Gallagher wrote:
>>>> Setting CFLAGS explicitly in configure.ac means that they would be
>>>> overwritten when using e.g. make CFLAGS="-O0 -g"
>>>> This replaces the explicit setting of CFLAGS with an
>>>> AM_CONDITIONAL to have Makefile.am set these instead.
>>> I would lean to think that being able to override the default CFLAGS
>>> with make CFLAGS="-O0 -g" is a feature not a bug.
>>> Is it not ?
>>>
>>> Simo.
>>>
>> I think you missed the point of this. That's the feature I was adding :)
>> What it was doing before this point was replacing the following CFLAGS
>> as well:
>> - -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual
>> - -Wcast-align -Wwrite-strings
>>
>> Now the CFLAGS= argument to make will append to those (overriding any
>> conflicting ones such as -O2).
> 
> Yeah I understood that, but I thought being able to completely override
> also the warnings might have been a feature.
> On a second thought though, better to always warn on issues so that
> developers don't get sloppy by suppress warnings and forgetting about
> them.
> 
> Ack.
> 

Pushed to master.
- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAko7kewACgkQeiVVYja6o6OlRwCdHXOLH4M4bCV2eXbmzGbnsJ1H
UakAnReQhNojpV5DbLzBG6e+9H/B0pSr
=eHIP
-----END PGP SIGNATURE-----