[Freeipa-devel] [PATCH] Check for valid ID ranges and ID overlaps between domains

Simo Sorce ssorce at redhat.com
Tue May 5 12:43:55 UTC 2009


On Tue, 2009-05-05 at 14:09 +0200, Jakub Hrozek wrote:
> attached.
> 
> Also if get_monitor_config returns != EOK in update_monitor_config,
> aborts the rest of update_monitor_config..I guess that if the config
> is
> wrong, we just want to carry on with the 'last known good config'.

nack

We do not require to always set id ranges, they are optional and more a
filter than anything else.
At most overlapping ranges should give a warning, and absence of ranges
in a domain is fine too.

Second I don't get the utility of the double while loop in that
function, what's for ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list